From 4a9c3f699132c93c2acea1b4447a76092e6ff384 Mon Sep 17 00:00:00 2001
From: SalahAlsabhi <mahkoom87@gmail.com>
Date: Tue, 8 Sep 2026 07:19:06 +0100
Subject: [PATCH 1/2] Build initial form controls

---
 Form-Controls/index.html | 28 +++++++++++++++++++++++-----
 1 file changed, 23 insertions(+), 5 deletions(-)

diff --git a/Form-Controls/index.html b/Form-Controls/index.html
index 74b591ffc..2236c5cfe 100644
--- a/Form-Controls/index.html
+++ b/Form-Controls/index.html
@@ -13,14 +13,32 @@ <h1>Product Pick</h1>
     </header>
     <main>
       <form>
-        <!-- write your html here-->
-        <!-- 
-          try writing out the requirements first as comments
-        this will also help you fill in your PR message later-->
+       <label for="name">NAME</label>
+       <input name="name" id="name" type="text" pattern=".*\S.*\S.*" />
+       <label for="email">Email</label>
+       <input id="email" type="email" required />
+       <fieldset>
+         <label id="colour" for="colour">Colour</label>
+         <input type="radio" name="colour" value="black" required />
+         <input type="radio" name="colour" value="white" required />
+         <input type="radio" name="colour" value="red" required />
+       </fieldset>
+       <label for="size">SIZE</label>
+       <select id="size" name="size" required>
+          <option value="">choose a size</option>
+          <option value="XS">XS</option>
+          <option value="S">S</option>
+          <option value="M">M</option>
+          <option value="L">L</option>
+          <option value="XL">XL</option>
+          <option value="XXL">XXL</option>
+       </select>
+       <label id="submit" for="submit"/label>
+       <button type="submit">Order T-shirt</button>
       </form>
     </main>
     <footer>
-      <!-- change to your name-->
+      Salah Alsabhi
       <p>By HOMEWORK SOLUTION</p>
     </footer>
   </body>

From 8a9cf2714d03f005d0361ac9eed9acf9f9aa2aad Mon Sep 17 00:00:00 2001
From: SalahAlsabhi <mahkoom87@gmail.com>
Date: Tue, 8 Sep 2026 11:19:15 +0100
Subject: [PATCH 2/2] Improve form accessibility and required field validation

---
 Form-Controls/index.html | 28 ++++++++++++++++------------
 1 file changed, 16 insertions(+), 12 deletions(-)

diff --git a/Form-Controls/index.html b/Form-Controls/index.html
index 2236c5cfe..36ca58689 100644
--- a/Form-Controls/index.html
+++ b/Form-Controls/index.html
@@ -13,17 +13,23 @@ <h1>Product Pick</h1>
     </header>
     <main>
       <form>
-       <label for="name">NAME</label>
-       <input name="name" id="name" type="text" pattern=".*\S.*\S.*" />
+       <label for="name">Name</label> 
+       <input name="name" id="name" type="text" pattern=".*\S.*\S.*" required />
        <label for="email">Email</label>
-       <input id="email" type="email" required />
+       <input id="email" name="email" type="email" required />
        <fieldset>
-         <label id="colour" for="colour">Colour</label>
-         <input type="radio" name="colour" value="black" required />
-         <input type="radio" name="colour" value="white" required />
-         <input type="radio" name="colour" value="red" required />
-       </fieldset>
-       <label for="size">SIZE</label>
+         <legend>T-shirt colour</legend>
+             <label>
+                  <input type="radio" name="colour" value="black" required />Black
+             </label>
+             <label>
+                  <input type="radio" name="colour" value="white" required />White
+             </label>
+             <label>
+                  <input type="radio" name="colour" value="red" required />Red
+              </label>
+         </fieldset>
+       <label for="size">Size</label>
        <select id="size" name="size" required>
           <option value="">choose a size</option>
           <option value="XS">XS</option>
@@ -33,13 +39,11 @@ <h1>Product Pick</h1>
           <option value="XL">XL</option>
           <option value="XXL">XXL</option>
        </select>
-       <label id="submit" for="submit"/label>
        <button type="submit">Order T-shirt</button>
       </form>
     </main>
     <footer>
-      Salah Alsabhi
-      <p>By HOMEWORK SOLUTION</p>
+       <p>By Salah Al-Sabhi</p>
     </footer>
   </body>
 </html>