From 565075bda96d2d4b45711294dc1caf7950a5d957 Mon Sep 17 00:00:00 2001 From: "fossifybot[bot]" <212866877+fossifybot[bot]@users.noreply.github.com> Date: Thu, 8 Oct 2026 00:54:18 +0000 Subject: [PATCH 1/2] chore(deps): bump org.fossify.commons from 6.1.6 to 7.1.0 --- gradle/libs.versions.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml index 4100dd62..f88f1f7b 100644 --- a/gradle/libs.versions.toml +++ b/gradle/libs.versions.toml @@ -11,7 +11,7 @@ androidx-window = "1.5.1" androidx-camera = "1.6.1" androidx-ktx = "2.10.0" #Fossify -commons = "6.1.6" +commons = "7.1.0" #Gradle gradlePlugins-agp = "9.4.1" #build From db89413d546c81b1b34c44ec4199e75751932188 Mon Sep 17 00:00:00 2001 From: Naveen Singh Date: Thu, 8 Oct 2026 06:59:22 +0530 Subject: [PATCH 2/2] fix: migrate to commons 7.1.0 --- app/build.gradle.kts | 1 - app/src/foss/res/values/bools.xml | 3 +- app/src/gplay/res/values/bools.xml | 3 +- .../camera/activities/SettingsActivity.kt | 32 ++++++++----------- 4 files changed, 16 insertions(+), 23 deletions(-) diff --git a/app/build.gradle.kts b/app/build.gradle.kts index c63f42be..5b48f731 100644 --- a/app/build.gradle.kts +++ b/app/build.gradle.kts @@ -82,7 +82,6 @@ android { flavorDimensions.add("variants") productFlavors { - register("core") register("foss") register("gplay") } diff --git a/app/src/foss/res/values/bools.xml b/app/src/foss/res/values/bools.xml index ac02880e..fcdfa946 100644 --- a/app/src/foss/res/values/bools.xml +++ b/app/src/foss/res/values/bools.xml @@ -1,6 +1,5 @@ true - true - true + false diff --git a/app/src/gplay/res/values/bools.xml b/app/src/gplay/res/values/bools.xml index 41c48b21..d89a62c6 100644 --- a/app/src/gplay/res/values/bools.xml +++ b/app/src/gplay/res/values/bools.xml @@ -1,6 +1,5 @@ false - false - true + true diff --git a/app/src/main/kotlin/org/fossify/camera/activities/SettingsActivity.kt b/app/src/main/kotlin/org/fossify/camera/activities/SettingsActivity.kt index fb727c75..7b359cfd 100644 --- a/app/src/main/kotlin/org/fossify/camera/activities/SettingsActivity.kt +++ b/app/src/main/kotlin/org/fossify/camera/activities/SettingsActivity.kt @@ -65,7 +65,7 @@ class SettingsActivity : SimpleActivity() { private fun refreshMenuItems() { binding.settingsToolbar.menu.apply { findItem(R.id.more_apps_from_us).isVisible = - !resources.getBoolean(org.fossify.commons.R.bool.hide_google_relations) + resources.getBoolean(org.fossify.commons.R.bool.is_google_play_build) } } @@ -116,7 +116,7 @@ class SettingsActivity : SimpleActivity() { FAQItem(R.string.faq_1_title, R.string.faq_1_text) ) - if (!resources.getBoolean(org.fossify.commons.R.bool.hide_google_relations)) { + if (resources.getBoolean(org.fossify.commons.R.bool.is_google_play_build)) { faqItems.add( FAQItem( org.fossify.commons.R.string.faq_2_title_commons, @@ -217,26 +217,22 @@ class SettingsActivity : SimpleActivity() { } private fun setupSavePhotosFolder() = binding.apply { - settingsSavePhotosLabel.text = addLockedLabelIfNeeded(R.string.save_photos) + settingsSavePhotosLabel.text = getString(R.string.save_photos) settingsSavePhotos.text = getLastPart(config.savePhotosFolder) settingsSavePhotosHolder.setOnClickListener { - if (isOrWasThankYouInstalled()) { - FilePickerDialog( - this@SettingsActivity, - config.savePhotosFolder, - false, - showFAB = true - ) { - val path = it - handleSAFDialog(it) { success -> - if (success) { - config.savePhotosFolder = path - settingsSavePhotos.text = getLastPart(config.savePhotosFolder) - } + FilePickerDialog( + this@SettingsActivity, + config.savePhotosFolder, + false, + showFAB = true + ) { + val path = it + handleSAFDialog(it) { success -> + if (success) { + config.savePhotosFolder = path + settingsSavePhotos.text = getLastPart(config.savePhotosFolder) } } - } else { - FeatureLockedDialog(this@SettingsActivity) { } } } }