Merge pull request #691 from apache/cleanup_names_phase_6

Cleanup names phase 6

Author: leerho

pom.xml

@@ -117,7 +117,7 @@ under the License.
     <!-- com.github plugins -->
     <git-commit-id-plugin.version>4.9.10</git-commit-id-plugin.version>
     <!-- org.apache.creadur plugins -->
-    <apache-rat-plugin.version>0.16.1</apache-rat-plugin.version>
+    <apache-rat-plugin.version>0.17</apache-rat-plugin.version>
     <!-- org.eluder maven plugins -->
     <coveralls-repo-token></coveralls-repo-token>
     <coveralls-maven-plugin.version>4.3.0</coveralls-maven-plugin.version>
@@ -332,19 +332,20 @@ under the License.
           <configuration>
             <outputDirectory>${project.basedir}/rat</outputDirectory>
             <consoleOutput>true</consoleOutput>
-            <useDefaultExcludes>true</useDefaultExcludes>
-            <excludes>
-              <!-- rat uses .gitignore for excludes by default -->
-              <exclude>**/*.yaml</exclude>
-              <exclude>**/*.yml</exclude>
-              <exclude>**/.*</exclude>
-              <exclude>**/test/resources/**/*.txt</exclude>
-              <exclude>**/git.properties</exclude>
-              <exclude>**/*.sk</exclude>
-              <exclude>LICENSE</exclude>
-              <exclude>NOTICE</exclude>
-              <exclude>**/*.code-workspace</exclude>
-            </excludes>
+            <inputExcludes>
+              <!-- I think rat uses .gitignore for excludes by default -->
+              <inputExcludeStd>StandardCollection</inputExcludeStd>
+              <inputExclude>**/*.yaml</inputExclude>
+              <inputExclude>**/*.yml</inputExclude>
+              <inputExclude>**/.*</inputExclude>
+              <inputExclude>**/test/resources/**/*.txt</inputExclude>
+              <inputExclude>**/git.properties</inputExclude>
+              <inputExclude>**/doc/**</inputExclude>
+              <inputExclude>**/*.sk</inputExclude>
+              <inputExclude>LICENSE</inputExclude>
+              <inputExclude>NOTICE</inputExclude>
+              <inputExclude>**/*.code-workspace</inputExclude>
+            </inputExcludes>
           </configuration>
         </plugin>
 

src/main/java/org/apache/datasketches/common/ArrayOfBooleansSerDe.java

@@ -30,6 +30,12 @@
  * @author Jon Malkin
  */
 public class ArrayOfBooleansSerDe extends ArrayOfItemsSerDe<Boolean> {
+
+  /**
+   * No argument constructor.
+   */
+  public ArrayOfBooleansSerDe() { }
+
   /**
    * Computes number of bytes needed for packed bit encoding of the array of booleans. Rounds
    * partial bytes up to return a whole number of bytes.

src/main/java/org/apache/datasketches/common/ArrayOfDoublesSerDe.java

@@ -32,6 +32,11 @@
  */
 public class ArrayOfDoublesSerDe extends ArrayOfItemsSerDe<Double> {
 
+  /**
+   * No argument constructor.
+   */
+  public ArrayOfDoublesSerDe() { }
+
   @Override
   public byte[] serializeToByteArray(final Double item) {
     Objects.requireNonNull(item, "Item must not be null");

src/main/java/org/apache/datasketches/common/ArrayOfItemsSerDe.java

@@ -30,6 +30,11 @@
  */
 public abstract class ArrayOfItemsSerDe<T> {
 
+  /**
+   * No argument constructor.
+   */
+  public ArrayOfItemsSerDe() { }
+
   /**
    * Serialize a single unserialized item to a byte array.
    *

src/main/java/org/apache/datasketches/common/ArrayOfLongsSerDe.java

@@ -32,6 +32,11 @@
  */
 public class ArrayOfLongsSerDe extends ArrayOfItemsSerDe<Long> {
 
+  /**
+   * No argument constructor.
+   */
+  public ArrayOfLongsSerDe() { }
+
   @Override
   public byte[] serializeToByteArray(final Long item) {
     Objects.requireNonNull(item, "Item must not be null");

src/main/java/org/apache/datasketches/common/ArrayOfNumbersSerDe.java

@@ -49,7 +49,6 @@
  * @author Jon Malkin
  */
 public class ArrayOfNumbersSerDe extends ArrayOfItemsSerDe<Number> {
-
   // values selected to enable backwards compatibility
   private static final byte LONG_INDICATOR    = 12;
   private static final byte INTEGER_INDICATOR = 9;
@@ -58,6 +57,11 @@ public class ArrayOfNumbersSerDe extends ArrayOfItemsSerDe<Number> {
   private static final byte DOUBLE_INDICATOR  = 4;
   private static final byte FLOAT_INDICATOR   = 6;
 
+  /**
+   * No argument constructor.
+   */
+  public ArrayOfNumbersSerDe() { }
+
   @Override
   public byte[] serializeToByteArray(final Number item) {
     Objects.requireNonNull(item, "Item must not be null");

src/main/java/org/apache/datasketches/common/ArrayOfStringsSerDe.java

@@ -41,6 +41,11 @@
  */
 public class ArrayOfStringsSerDe extends ArrayOfItemsSerDe<String> {
 
+  /**
+   * No argument constructor.
+   */
+  public ArrayOfStringsSerDe() { }
+
   @Override
   public byte[] serializeToByteArray(final String item) {
     Objects.requireNonNull(item, "Item must not be null");

src/main/java/org/apache/datasketches/common/ArrayOfUtf16StringsSerDe.java

@@ -39,6 +39,11 @@
  */
 public class ArrayOfUtf16StringsSerDe extends ArrayOfItemsSerDe<String> {
 
+  /**
+   * No argument constructor.
+   */
+  public ArrayOfUtf16StringsSerDe() { }
+
   @Override
   public byte[] serializeToByteArray(final String item) {
     Objects.requireNonNull(item, "Item must not be null");

src/main/java/org/apache/datasketches/common/ByteArrayUtil.java

@@ -25,6 +25,11 @@
  */
 public final class ByteArrayUtil {
 
+  /**
+   * No argument constructor.
+   */
+  public ByteArrayUtil() { }
+
   /**
    * Copies bytes from source to target with offsets on both the source and target.
    * @param source the given source

src/main/java/org/apache/datasketches/common/MemorySegmentRequest.java

@@ -53,10 +53,14 @@ default void requestClose(final MemorySegment prevSeg) {
   }
 
   /**
-   * This class implements the defaults
+   * A convenience class that implements a default implementation.
    */
   public static class Default implements MemorySegmentRequest {
-    //A convenience class that creates the target for the static member DEFAULT.
+
+    /**
+     * No argument constructor that creates the target for the static member DEFAULT.
+     */
+    public Default() { }
   }
 
   /**