Skip to content

http. RoundTripper is not re-used #10

Description

@pavelmemory

For the bitbucketserver and github vcsclient(s) the http.RoundTripper is not re-used, but created for each new request if client.vcsInfo.Token is provided.
This can cause an issue because connections acquire file descriptors and won't be released immediately after http.Client garbage collection, please see https://golang.org/src/net/http/transport.go#L68

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions