From cdffded771ca52aa7cff0a0f83cbd51917b4484f Mon Sep 17 00:00:00 2001 From: Cody Spath Date: Fri, 25 Sep 2026 15:44:08 -0400 Subject: [PATCH] chore: prepare release 2.18.3 Prepares the 2.18.3 release by hand, same approach as 2.18.2 in #622 and 2.18.1 in #620: rulesets block the release workflow from pushing version bumps straight to main, so the bump lands as a normal PR. Re-release of 2.18.2 under correct artifact names. No code changes -- only the version constant, the changelog and the Action metadata pins. v2.18.2 published all 15 archives named 2.18.1. The binaries were correct (verified go-toml v2.4.3 and go1.26.8 inside the published asset), but goreleaser templated the filenames from the newest tag it could see rather than the release tag, because products-for-release passes --skip-validate and suppresses the tag/HEAD check. Two consequences: the Homebrew formula, generated from the real tag, points at 2.18.2 filenames that 404, so brew install is broken; and ld-find-code-refs_2.18.1_*.tar.gz now exists on two releases with different contents. The v2.18.2 tag is immutable, so neither can be fixed in place. When building artifacts for this release, force the version instead of letting goreleaser infer it, and check the names rather than just the count: GORELEASER_CURRENT_TAG=v2.18.3 make products-for-release ls -1 dist/*.tar.gz | grep -c '2\.18\.3' # expect 8 Then create the release as a draft with all 15 assets, verify both the count and the filenames, and only then publish. Co-Authored-By: Claude Opus 5 --- CHANGELOG.md | 5 +++++ build/metadata/github-actions/Dockerfile | 2 +- build/metadata/github-actions/README.md | 8 ++++---- build/metadata/github-actions/docker/action.yml | 4 ++-- internal/version/version.go | 2 +- 5 files changed, 13 insertions(+), 8 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c3eb6256..91b442db 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,11 @@ All notable changes to the ld-find-code-refs program will be documented in this ## [Unreleased] +## [2.18.3] - 2026-09-25 + +### Fixed: +- the v2.18.2 release archives were published with `2.18.1` filenames, because `make products-for-release` passes `--skip-validate` and goreleaser fell back to the newest visible tag when naming artifacts. The binaries themselves were correct, but the Homebrew formula pointed at `2.18.2` filenames that did not exist, and the misnamed archives collided with the genuine v2.18.1 assets. This release republishes the same code under correctly named artifacts. There are no code changes from 2.18.2 -- the go-toml v2.4.3 bump released there is unchanged + ## [2.18.2] - 2026-09-25 ### Fixed: diff --git a/build/metadata/github-actions/Dockerfile b/build/metadata/github-actions/Dockerfile index 38a9d10d..fb48aa34 100644 --- a/build/metadata/github-actions/Dockerfile +++ b/build/metadata/github-actions/Dockerfile @@ -1,4 +1,4 @@ -FROM launchdarkly/ld-find-code-refs-github-action:2.18.2 +FROM launchdarkly/ld-find-code-refs-github-action:2.18.3 LABEL com.github.actions.name="LaunchDarkly Code References" LABEL com.github.actions.description="Find references to feature flags in your code." diff --git a/build/metadata/github-actions/README.md b/build/metadata/github-actions/README.md index 55c54730..a836dfae 100644 --- a/build/metadata/github-actions/README.md +++ b/build/metadata/github-actions/README.md @@ -28,7 +28,7 @@ jobs: with: fetch-depth: 11 # This value must be set if the lookback configuration option is not disabled for find-code-references. Read more: https://github.com/launchdarkly/ld-find-code-refs#searching-for-unused-flags-extinctions - name: LaunchDarkly Code References - uses: launchdarkly/find-code-references@v2.18.2 + uses: launchdarkly/find-code-references@v2.18.3 with: accessToken: ${{ secrets.LD_ACCESS_TOKEN }} projKey: LD_PROJECT_KEY @@ -64,11 +64,11 @@ jobs: password: ${{ secrets.REGISTRY_TOKEN }} - name: LaunchDarkly Code References # Pin to a release that includes the docker/ entry point (see changelog). - uses: launchdarkly/find-code-references/docker@v2.18.2 + uses: launchdarkly/find-code-references/docker@v2.18.3 with: accessToken: ${{ secrets.LD_ACCESS_TOKEN }} projKey: LD_PROJECT_KEY - dockerImage: your.registry.example/launchdarkly/ld-find-code-refs-github-action:2.18.2 + dockerImage: your.registry.example/launchdarkly/ld-find-code-refs-github-action:2.18.3 ``` Mirror the public image `launchdarkly/ld-find-code-refs-github-action` into your registry (pin `dockerImage` to the scanner image tag you mirrored; it can lag the Action tag). This entry point requires a Docker CLI on the runner (included on GitHub-hosted `ubuntu-*` runners). Existing workflows that use the root Action do not need to change. @@ -104,7 +104,7 @@ jobs: with: fetch-depth: 11 # This value must be set if the lookback configuration option is not disabled for find-code-references. Read more: https://github.com/launchdarkly/ld-find-code-refs#searching-for-unused-flags-extinctions - name: LaunchDarkly Code References - uses: launchdarkly/find-code-references@v2.18.2 + uses: launchdarkly/find-code-references@v2.18.3 with: accessToken: ${{ secrets.LD_ACCESS_TOKEN }} projKey: LD_PROJECT_KEY diff --git a/build/metadata/github-actions/docker/action.yml b/build/metadata/github-actions/docker/action.yml index 2eb3def8..d2b506e1 100644 --- a/build/metadata/github-actions/docker/action.yml +++ b/build/metadata/github-actions/docker/action.yml @@ -52,12 +52,12 @@ inputs: description: >- Container image to run. Defaults to the public Docker Hub image used by the root Action. Set this to your mirrored/proxy image (for example - your.registry.example/launchdarkly/ld-find-code-refs-github-action:2.18.2). + your.registry.example/launchdarkly/ld-find-code-refs-github-action:2.18.3). Authenticate to private registries with docker/login-action (or equivalent) in a prior step. Requires a runner with a Docker CLI (GitHub-hosted ubuntu-* runners include one). required: false - default: "launchdarkly/ld-find-code-refs-github-action:2.18.2" + default: "launchdarkly/ld-find-code-refs-github-action:2.18.3" runs: using: composite steps: diff --git a/internal/version/version.go b/internal/version/version.go index 6832086f..473a6f18 100644 --- a/internal/version/version.go +++ b/internal/version/version.go @@ -1,3 +1,3 @@ package version -const Version = "2.18.2" +const Version = "2.18.3"