From 239cdc9ab7e27fe24a4211c1af7fda1ef6fcc2b7 Mon Sep 17 00:00:00 2001 From: Tycho Hob Date: Fri, 16 Oct 2026 15:54:06 -0400 Subject: [PATCH] revert: "fix: render certificates when no About URL is configured" This reverts commit aced8af9654f9a226726a9ca11c066bcb5744500. That commit was pushed to master directly by mistake, without a pull request or review. Reverting it so the change can come back through a normal PR. Co-Authored-By: Claude Opus 5.5 --- .../certificates/tests/test_webview_views.py | 20 ------------------- lms/templates/certificates/_about-edx.html | 4 +--- 2 files changed, 1 insertion(+), 23 deletions(-) diff --git a/lms/djangoapps/certificates/tests/test_webview_views.py b/lms/djangoapps/certificates/tests/test_webview_views.py index c3b88bac17bc..9817ecd290a3 100644 --- a/lms/djangoapps/certificates/tests/test_webview_views.py +++ b/lms/djangoapps/certificates/tests/test_webview_views.py @@ -611,26 +611,6 @@ def test_render_html_view_valid_certificate(self): response = self.client.get(test_url) self.assertContains(response, str(self.cert.verify_uuid)) - @override_settings(CERTIFICATES_HTML_VIEW=True) - def test_render_html_view_without_about_url(self): - """ - Tests that the certificate renders when no About page URL is configured - anywhere: not in the HTML view configuration, the site configuration or - the marketing URLs. The "Learn more" link is left out rather than the - template failing on an undefined name. - """ - CertificateHtmlViewConfigurationFactory.create(enabled=False) - self._add_course_certificates(count=1, signatory_count=1) - test_url = get_certificate_url( - user_id=self.user.id, - course_id=str(self.course.id), - uuid=self.cert.verify_uuid - ) - response = self.client.get(test_url) - self.assertContains(response, str(self.cert.verify_uuid)) - self.assertContains(response, 'class="about-item about-edx"') - self.assertNotContains(response, 'Learn more about') - @override_settings(CERTIFICATES_HTML_VIEW=True) def test_render_certificate_only_for_downloadable_status(self): """ diff --git a/lms/templates/certificates/_about-edx.html b/lms/templates/certificates/_about-edx.html index e25e292d45e0..70b030852519 100644 --- a/lms/templates/certificates/_about-edx.html +++ b/lms/templates/certificates/_about-edx.html @@ -6,8 +6,6 @@

${company_about_title}

${company_about_description}

- % if company_about_url is not UNDEFINED: - ${company_about_urltext} - % endif + ${company_about_urltext}