Skip to content

Commit 36be2bc

Browse files
committed
gh-158169: Simplify zlib EOF regression test
1 parent 7d19724 commit 36be2bc

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

‎Lib/test/test_zlib.py‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -823,14 +823,14 @@ def test_decompress_unused_data(self):
823823
self.assertEqual(dco.unused_data, remainder)
824824

825825
def test_decompress_unconsumed_tail_after_eof(self):
826-
source = bytes(range(256)) * 4
827-
remainder = b'extra'
826+
source = b'abcdefghijklmnopqrstuvwxyz'
827+
remainder = b'0123456789'
828828
dco = zlib.decompressobj()
829-
chunks = [dco.decompress(zlib.compress(source) + remainder, 100)]
830-
while not dco.eof:
831-
chunks.append(dco.decompress(dco.unconsumed_tail, 100))
829+
data = dco.decompress(zlib.compress(source) + remainder, 1)
830+
data += dco.decompress(dco.unconsumed_tail)
832831

833-
self.assertEqual(b''.join(chunks), source)
832+
self.assertTrue(dco.eof)
833+
self.assertEqual(data, source)
834834
self.assertEqual(dco.unconsumed_tail, b'')
835835
self.assertEqual(dco.unused_data, remainder)
836836

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
Clear ``Decompress.unconsumed_tail`` once decompression reaches EOF. Trailing
2-
input is available only through ``Decompress.unused_data``.
1+
Fix :attr:`zlib.Decompress.unconsumed_tail` duplicating
2+
:attr:`~zlib.Decompress.unused_data` after end of stream when *max_length* was used.

0 commit comments

Comments
 (0)