Skip to content

Commit bb976a6

Browse files
committed
Address PR feedback
1 parent 2aa1794 commit bb976a6

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

‎Lib/_colorize.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -603,7 +603,7 @@ def _safe_getenv(k: str, fallback: str | None = None) -> str | None:
603603
return os.isatty(file.fileno())
604604
except OSError:
605605
return hasattr(file, "isatty") and file.isatty()
606-
except Exception:
606+
except ValueError:
607607
return False
608608

609609

‎Lib/test/test__colorize.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ def test_colorized_detection_checks_for_file(self):
191191
# gh-157581: A closed file raises ValueError from fileno().
192192
file = tempfile.TemporaryFile(mode="w")
193193
file.close()
194-
self.assertEqual(_colorize.can_colorize(file=file), False)
194+
self.assertFalse(_colorize.can_colorize(file=file))
195195

196196

197197
if __name__ == "__main__":
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Updated ``can_colorize`` logic in ``_colorize.py`` to catch all exceptions when checking if a file is a TTY, returning ``False`` if any exception occurs. This prevents crashes in edge cases, such as when a file is closed.
1+
Updated :func:``!_colorize.can_colorize`` to not raise when given a closed file stream.

0 commit comments

Comments
 (0)