From c0b8db2dd9d77d23913767ca9a0b75bf68a19c8a Mon Sep 17 00:00:00 2001 From: Grant Birchmeier Date: Thu, 24 Sep 2026 12:44:03 -0500 Subject: [PATCH] correct error message in SessionFactory --- session_factory.go | 12 ++++++------ session_factory_test.go | 8 ++++++++ 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/session_factory.go b/session_factory.go index 1b79f5ee1..60829ee42 100644 --- a/session_factory.go +++ b/session_factory.go @@ -147,16 +147,16 @@ func (f sessionFactory) newSession( if s.transportDataDictionary, err = datadictionary.Parse(transportDataDictionaryPath); err != nil { err = errors.Wrapf( - err, "problem parsing XML datadictionary path '%v' for setting '%v", - settings.settings[config.TransportDataDictionary], config.TransportDataDictionary, + err, "problem parsing XML datadictionary path '%v' for setting '%v'", + string(settings.settings[config.TransportDataDictionary]), config.TransportDataDictionary, ) return } if s.appDataDictionary, err = datadictionary.Parse(appDataDictionaryPath); err != nil { err = errors.Wrapf( - err, "problem parsing XML datadictionary path '%v' for setting '%v", - settings.settings[config.AppDataDictionary], config.AppDataDictionary, + err, "problem parsing XML datadictionary path '%v' for setting '%v'", + string(settings.settings[config.AppDataDictionary]), config.AppDataDictionary, ) return } @@ -171,8 +171,8 @@ func (f sessionFactory) newSession( if s.appDataDictionary, err = datadictionary.Parse(dataDictionaryPath); err != nil { err = errors.Wrapf( - err, "problem parsing XML datadictionary path '%v' for setting '%v", - settings.settings[config.DataDictionary], config.DataDictionary, + err, "problem parsing XML datadictionary path '%v' for setting '%v'", + string(settings.settings[config.DataDictionary]), config.DataDictionary, ) return } diff --git a/session_factory_test.go b/session_factory_test.go index 349e7580c..63bf18ae5 100644 --- a/session_factory_test.go +++ b/session_factory_test.go @@ -744,3 +744,11 @@ func (s *SessionFactorySuite) TestPersistMessages() { s.Equal(test.expected, session.DisableMessagePersist) } } + +func (s *SessionFactorySuite) TestBadDictionaryPath() { + s.SetupTest() + s.SessionSettings.Set(config.DataDictionary, "file/does/not/exist.xml") + _, err := s.newSession(s.SessionID, s.MessageStoreFactory, s.SessionSettings, s.LogFactory, s.App) + s.NotNil(err) + s.Contains(err.Error(), "problem parsing XML datadictionary path 'file/does/not/exist.xml' for setting 'DataDictionary':") +}