From 6618bc65559bbcf48eff72f7fe7085a78b9fafd7 Mon Sep 17 00:00:00 2001 From: Tan Date: Sun, 21 Sep 2025 13:12:57 -0400 Subject: [PATCH 1/6] remove check-envvar-print from check_built() - r-lib/rcmdcheck#237 --- R/check.R | 4 ---- 1 file changed, 4 deletions(-) diff --git a/R/check.R b/R/check.R index 5e49fc945..ed39789a0 100644 --- a/R/check.R +++ b/R/check.R @@ -224,10 +224,6 @@ check_built <- function( } env_vars <- check_env_vars(cran, remote, incoming, force_suggests, env_vars) - if (!quiet) { - cli::cat_rule("Checking", col = "cyan", line = 2) - show_env_vars(env_vars) - } withr::with_envvar(env_vars, action = "replace", { rcmdcheck::rcmdcheck( From 00ff68a93ebe827c4a28178b27a83e4cc7d2e61d Mon Sep 17 00:00:00 2001 From: Tan Date: Sun, 21 Sep 2025 13:17:23 -0400 Subject: [PATCH 2/6] update news --- NEWS.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/NEWS.md b/NEWS.md index 03da4ddb6..12be8a14d 100644 --- a/NEWS.md +++ b/NEWS.md @@ -54,6 +54,8 @@ Other improvements * `dev_mode()` and `check_rhub()` are deprecated. +* `check_built()` no longer prints check env variables - now handled by `rcmdcheck::rcmdcheck()` directly as of r-lib/rcmdcheck#237 (#2621) + # devtools 2.4.5 * `check(cleanup =)` was deprecated in devtools v1.11.0 (2016-04-12) and was From 20434b3a149afe6731adad228082054e19ee3fd4 Mon Sep 17 00:00:00 2001 From: Hadley Wickham Date: Wed, 21 Jan 2026 11:20:06 -0600 Subject: [PATCH 3/6] Move bullet to correct place --- NEWS.md | 1 + 1 file changed, 1 insertion(+) diff --git a/NEWS.md b/NEWS.md index 12be8a14d..94f72f8fa 100644 --- a/NEWS.md +++ b/NEWS.md @@ -37,6 +37,7 @@ Other improvements * `check_mac_devel()` is a new function to check a package using the macOS builder at https://mac.r-project.org/macbuilder/submit.html (@nfrerebeau, #2507) * `check_win()` and friends gain a `webform` argument that uses a webform instead of passive FTP upload (@brownag, #2619). * `dev_sitrep()` now works correctly inside Positron (#2618), uses pak instead of remotes to check for dependencies that are missing/behind/ahead (#2663), and uses cli for user-facing messages. +* `check_built()` no longer prints `R_CHECK_` check env variables - now handled by `rcmdcheck::rcmdcheck()` directly as of r-lib/rcmdcheck#237 (#2621) * `is_loading()` is now re-exported from pkgload (#2556). * `load_all()` now errors if called recursively, i.e. if you accidentally include a `load_all()` call in one of your R source files (#2617). * `show_news()` now looks for NEWS files in the same locations as `utils::news()`: `inst/NEWS.Rd`, `NEWS.md`, `NEWS`, and `inst/NEWS` (@arcresu, #2499). From 4e543016c1b4ab2c60fd006caaec21d13e7b0399 Mon Sep 17 00:00:00 2001 From: Tan Ho <38083823+tanho63@users.noreply.github.com> Date: Thu, 17 Sep 2026 12:34:22 -0400 Subject: [PATCH 4/6] Revise NEWS.md for devtools updates Updated NEWS.md to reflect changes in devtools, including new functions and behavioral updates. --- NEWS.md | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/NEWS.md b/NEWS.md index 94f72f8fa..01775391d 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,6 +1,7 @@ # devtools (development version) * `submit_cran()` gives a more informative error when the CRAN submission form can't be used, suggesting that the user consult to see if there's a CRAN closure (#2700). +* `check_built()` no longer prints `R_CHECK_` check env variables - now handled by `rcmdcheck::rcmdcheck()` directly as of r-lib/rcmdcheck#237 (#2621) # devtools 2.5.2 @@ -37,7 +38,6 @@ Other improvements * `check_mac_devel()` is a new function to check a package using the macOS builder at https://mac.r-project.org/macbuilder/submit.html (@nfrerebeau, #2507) * `check_win()` and friends gain a `webform` argument that uses a webform instead of passive FTP upload (@brownag, #2619). * `dev_sitrep()` now works correctly inside Positron (#2618), uses pak instead of remotes to check for dependencies that are missing/behind/ahead (#2663), and uses cli for user-facing messages. -* `check_built()` no longer prints `R_CHECK_` check env variables - now handled by `rcmdcheck::rcmdcheck()` directly as of r-lib/rcmdcheck#237 (#2621) * `is_loading()` is now re-exported from pkgload (#2556). * `load_all()` now errors if called recursively, i.e. if you accidentally include a `load_all()` call in one of your R source files (#2617). * `show_news()` now looks for NEWS files in the same locations as `utils::news()`: `inst/NEWS.Rd`, `NEWS.md`, `NEWS`, and `inst/NEWS` (@arcresu, #2499). @@ -55,8 +55,6 @@ Other improvements * `dev_mode()` and `check_rhub()` are deprecated. -* `check_built()` no longer prints check env variables - now handled by `rcmdcheck::rcmdcheck()` directly as of r-lib/rcmdcheck#237 (#2621) - # devtools 2.4.5 * `check(cleanup =)` was deprecated in devtools v1.11.0 (2016-04-12) and was From 8fb7aafc7a144e2cd8a8e6817f3261f53870b0d8 Mon Sep 17 00:00:00 2001 From: Tan Ho Date: Thu, 17 Sep 2026 12:36:59 -0400 Subject: [PATCH 5/6] update remotes to make work while rcmdcheck#237 is still unmerged --- DESCRIPTION | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/DESCRIPTION b/DESCRIPTION index 09d596d90..a93e858a6 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -30,7 +30,7 @@ Imports: pkgdown (>= 2.2.0), pkgload (>= 1.5.2), profvis (>= 0.4.0), - rcmdcheck (>= 1.4.0), + rcmdcheck (>= 1.4.0.9001), rlang (>= 1.2.0), roxygen2 (>= 7.3.3), rversions (>= 3.0.0), @@ -57,6 +57,8 @@ Suggests: spelling (>= 2.2), xml2 VignetteBuilder: knitr, quarto +Remotes: + r-lib/rcmdcheck#237 Config/Needs/website: tidyverse/tidytemplate Config/testthat/edition: 3 Config/testthat/parallel: true From 1ba8a308e3e9ed75567587d8502e4e264edd9493 Mon Sep 17 00:00:00 2001 From: Tan Ho <38083823+tanho63@users.noreply.github.com> Date: Wed, 23 Sep 2026 20:48:30 -0400 Subject: [PATCH 6/6] Apply suggestion from @tanho63 --- DESCRIPTION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DESCRIPTION b/DESCRIPTION index 8819a34bc..36f62d305 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -57,7 +57,7 @@ Suggests: spelling (>= 2.2), xml2 Remotes: - r-lib/rcmdcheck#237 + r-lib/rcmdcheck VignetteBuilder: knitr, quarto