Skip to content

Commit d2083a9

Browse files
authored
ci(e2e): skip the duplicate type pass and source maps in the mobile build (#8982)
1 parent d29b0b6 commit d2083a9

3 files changed

Lines changed: 9 additions & 3 deletions

File tree

‎.github/workflows/checks.yml‎

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -890,14 +890,19 @@ jobs:
890890
AWS_REGION: 'us-west-2'
891891
ENCRYPTION_KEY: '0000000000000000000000000000000000000000000000000000000000000000' # dummy key for CI only
892892
TURBO_CACHE_DIR: .turbo
893+
# This build is on the e2e-mobile critical path; its ~30 s TypeScript pass repeats what
894+
# lint's type-check and the `build` job's own `next build` (generated route types too)
895+
# already enforce.
896+
NEXT_BUILD_SKIP_TYPE_CHECK: 'true'
893897
run: bunx turbo run build --filter=@sim/app
894898

895899
# Everything `next start` reads; node_modules and the source tree come from e2e-mobile's own
896-
# checkout and setup, at the same workspace path and lockfile.
900+
# checkout and setup, at the same workspace path and lockfile. Source maps are over half the
901+
# build and only serve stack traces and devtools, which the suite never reads.
897902
- name: Package the build for e2e-mobile
898903
run: >-
899904
tar -I 'zstd -T0' -cf "$RUNNER_TEMP/next-build.tar.zst" -C apps/sim
900-
--exclude .next/cache --exclude .next/trace .next
905+
--exclude .next/cache --exclude .next/trace --exclude '*.map' .next
901906
902907
# Already zstd-compressed, so stored without zip compression. `overwrite` lets a re-run of
903908
# this job replace the earlier attempt's build; three days covers re-running a failed shard

‎apps/sim/lib/core/config/env.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -333,6 +333,7 @@ export const env = createEnv({
333333
// Infrastructure & Deployment
334334
NEXT_RUNTIME: z.string().optional(), // Next.js runtime environment
335335
DOCKER_BUILD: z.boolean().optional(), // Flag indicating Docker build environment
336+
NEXT_BUILD_SKIP_TYPE_CHECK: z.boolean().optional(), // Skips `next build`'s TypeScript pass where another CI job type-checks
336337

337338
// Background Jobs & Scheduling
338339
TRIGGER_PROJECT_ID: z.string().optional(), // Trigger.dev project ID

‎apps/sim/next.config.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ const nextConfig: NextConfig = {
8989
],
9090
},
9191
typescript: {
92-
ignoreBuildErrors: isTruthy(env.DOCKER_BUILD),
92+
ignoreBuildErrors: isTruthy(env.DOCKER_BUILD) || isTruthy(env.NEXT_BUILD_SKIP_TYPE_CHECK),
9393
},
9494
output: isTruthy(env.DOCKER_BUILD) ? 'standalone' : undefined,
9595
serverExternalPackages: [

0 commit comments

Comments
 (0)