From 41524d50ad57bc81b5beb679fbcbc843cb5eaa7a Mon Sep 17 00:00:00 2001 From: kgryte Date: Sun, 4 Oct 2026 10:29:39 +0000 Subject: [PATCH] test: migrate `stats/base/dists/discrete-uniform/logpmf` to ULP-based assertions Replace relative tolerance assertions with ULP-based assertions using `@stdlib/assert/is-almost-same-value`. The ULP bound was tightened to the measured minimum of 1 ULP across all fixture sets for the main, factory, and native implementations. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01FJKn4dpTUjRm6CFGRXBkdh --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../logpmf/test/test.factory.js | 33 +++---------------- .../logpmf/test/test.logpmf.js | 33 +++---------------- .../logpmf/test/test.native.js | 33 +++---------------- 3 files changed, 12 insertions(+), 87 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/discrete-uniform/logpmf/test/test.factory.js b/lib/node_modules/@stdlib/stats/base/dists/discrete-uniform/logpmf/test/test.factory.js index 29c20a1c8fa2..e8e5ddc0edb8 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/discrete-uniform/logpmf/test/test.factory.js +++ b/lib/node_modules/@stdlib/stats/base/dists/discrete-uniform/logpmf/test/test.factory.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var factory = require( './../lib/factory.js' ); @@ -144,8 +143,6 @@ tape( 'if provided `a > b`, the created function always returns `NaN`', function tape( 'the created function evaluates the logpmf for `x` given small range `b - a`', function test( t ) { var expected; var logpmf; - var delta; - var tol; var a; var b; var i; @@ -159,13 +156,7 @@ tape( 'the created function evaluates the logpmf for `x` given small range `b - for ( i = 0; i < x.length; i++ ) { logpmf = factory( a[i], b[i] ); y = logpmf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); }); @@ -173,8 +164,6 @@ tape( 'the created function evaluates the logpmf for `x` given small range `b - tape( 'the created function evaluates the logpmf for `x` given a medium range `b - a`', function test( t ) { var expected; var logpmf; - var delta; - var tol; var a; var b; var i; @@ -188,13 +177,7 @@ tape( 'the created function evaluates the logpmf for `x` given a medium range `b for ( i = 0; i < x.length; i++ ) { logpmf = factory( a[i], b[i] ); y = logpmf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); }); @@ -202,8 +185,6 @@ tape( 'the created function evaluates the logpmf for `x` given a medium range `b tape( 'the created function evaluates the logpmf for `x` given a large range `b - a`', function test( t ) { var expected; var logpmf; - var delta; - var tol; var a; var b; var i; @@ -217,13 +198,7 @@ tape( 'the created function evaluates the logpmf for `x` given a large range `b for ( i = 0; i < x.length; i++ ) { logpmf = factory( a[i], b[i] ); y = logpmf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/discrete-uniform/logpmf/test/test.logpmf.js b/lib/node_modules/@stdlib/stats/base/dists/discrete-uniform/logpmf/test/test.logpmf.js index bc19e47d84a2..072f6e1107ae 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/discrete-uniform/logpmf/test/test.logpmf.js +++ b/lib/node_modules/@stdlib/stats/base/dists/discrete-uniform/logpmf/test/test.logpmf.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var logpmf = require( './../lib' ); @@ -90,8 +89,6 @@ tape( 'if provided `a > b`, the function returns `NaN`', function test( t ) { tape( 'the function evaluates the logpmf for `x` given a small range `b - a`', function test( t ) { var expected; - var delta; - var tol; var x; var a; var b; @@ -104,21 +101,13 @@ tape( 'the function evaluates the logpmf for `x` given a small range `b - a`', f b = smallRange.b; for ( i = 0; i < x.length; i++ ) { y = logpmf( x[i], a[i], b[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the logpmf for `x` given a medium range `b - a`', function test( t ) { var expected; - var delta; - var tol; var x; var a; var b; @@ -131,21 +120,13 @@ tape( 'the function evaluates the logpmf for `x` given a medium range `b - a`', b = mediumRange.b; for ( i = 0; i < x.length; i++ ) { y = logpmf( x[i], a[i], b[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the logpmf for `x` given a large range `b - a`', function test( t ) { var expected; - var delta; - var tol; var x; var a; var b; @@ -158,13 +139,7 @@ tape( 'the function evaluates the logpmf for `x` given a large range `b - a`', f b = largeRange.b; for ( i = 0; i < x.length; i++ ) { y = logpmf( x[i], a[i], b[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/discrete-uniform/logpmf/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/discrete-uniform/logpmf/test/test.native.js index e19e972558bb..0c2f54d10467 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/discrete-uniform/logpmf/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/discrete-uniform/logpmf/test/test.native.js @@ -22,11 +22,10 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var tryRequire = require( '@stdlib/utils/try-require' ); @@ -83,8 +82,6 @@ tape( 'if provided `a > b`, the function returns `NaN`', opts, function test( t tape( 'the function evaluates the logpmf for `x` given a small range `b - a`', opts, function test( t ) { var expected; - var delta; - var tol; var x; var a; var b; @@ -97,21 +94,13 @@ tape( 'the function evaluates the logpmf for `x` given a small range `b - a`', o b = smallRange.b; for ( i = 0; i < x.length; i++ ) { y = logpmf( x[i], a[i], b[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the logpmf for `x` given a medium range `b - a`', opts, function test( t ) { var expected; - var delta; - var tol; var x; var a; var b; @@ -124,21 +113,13 @@ tape( 'the function evaluates the logpmf for `x` given a medium range `b - a`', b = mediumRange.b; for ( i = 0; i < x.length; i++ ) { y = logpmf( x[i], a[i], b[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the logpmf for `x` given a large range `b - a`', opts, function test( t ) { var expected; - var delta; - var tol; var x; var a; var b; @@ -151,13 +132,7 @@ tape( 'the function evaluates the logpmf for `x` given a large range `b - a`', o b = largeRange.b; for ( i = 0; i < x.length; i++ ) { y = logpmf( x[i], a[i], b[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); });