Skip to content

TEST: Run the cloud tests again, and let a property have no value #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jwrosewell wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

TEST: Run the cloud tests again, and let a property have no value #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions ip-intelligence.cloud/src/test/java/fiftyone/ipintelligence/cloud/ValueTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,25 @@ public static void valueTypes(WrapperCloud wrapper) throws Exception {

assertNotNull("Value of " + property.getName() + " is null. ", value);
assertTrue(AspectPropertyValue.class.isAssignableFrom(value.getClass()));
AspectPropertyValue<?> propertyValue =
(AspectPropertyValue<?>) value;
// A property the resource key is not entitled to, or one
// the client script populates, is listed but carries no
// value and says why instead. Asking such a value for its
// type throws, so what is checked here is that the reason
// was given, which is what a caller reads.
if (propertyValue.hasValue() == false) {
assertNotNull("Property '" + property.getName() +
"' has no value and no reason was given.",
propertyValue.getNoValueMessage());
continue;
}
assertTrue("Value of '" + property.getName() +
"' was of type " + ((AspectPropertyValue<?>) value).getValue().getClass().getSimpleName() +
"' was of type " + propertyValue.getValue().getClass().getSimpleName() +
" but should have been " + expectedType.getSimpleName() +
".",
expectedType.isAssignableFrom(
((AspectPropertyValue<?>) value).getValue().getClass()));
propertyValue.getValue().getClass()));
}
}
}
Expand Down
2 changes: 0 additions & 2 deletions ip-intelligence.cloud/src/test/java/fiftyone/ipintelligence/cloud/data/ValueCloudTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,8 @@

import org.junit.After;
import org.junit.Before;
import org.junit.Ignore;
import org.junit.Test;

@Ignore
public class ValueCloudTests extends TestsBase {

@Before
Expand Down
4 changes: 1 addition & 3 deletions ...rc/test/java/fiftyone/ipintelligence/cloud/flowelements/MissingPropertyHandlingTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
import fiftyone.pipeline.engines.services.MissingPropertyReason;
import fiftyone.pipeline.engines.services.MissingPropertyResult;
import fiftyone.pipeline.engines.services.MissingPropertyService;
import org.junit.Ignore;
import org.junit.Test;
import org.slf4j.ILoggerFactory;
import org.slf4j.LoggerFactory;
Expand All @@ -46,7 +45,6 @@
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;

@Ignore
public class MissingPropertyHandlingTests {

protected static final ILoggerFactory loggerFactory = LoggerFactory.getILoggerFactory();
Expand Down Expand Up @@ -136,7 +134,7 @@ public void PropertyNotInResource() throws Exception {

private static String nullValueJson =
"{\n" +
" 'ip-intelligence': {\n" +
" 'ip': {\n" +
" 'registeredname': 'Example Network',\n" +
" 'registeredcountry': 'US',\n" +
" 'latitude': null,\n" +
Expand Down
Loading