CI: Fall back to main for examples and pass the resource key to pull request tests - #180
Merged
Merged
Conversation
YaroslavVlasenko
marked this pull request as draft
September 17, 2026 18:53
This was referenced Sep 17, 2026
YaroslavVlasenko
marked this pull request as ready for review
September 18, 2026 10:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
The
Pull Requestsworkflow fails on any branch that is notmain. The three runs above show two separate causes, both in the CI setup.1. Examples are cloned by the name of the branch under test
ci/run-integration-tests.ps1andci/run-performance-tests.ps1cloneip-intelligence-java-exampleswith-Branch $Branch, and common-ci fills$Branchwith the branch being tested. When the examples repo has no branch with that name the clone stops with:Pairing branches by name was added on purpose in #67 and is kept. The scripts now ask the examples repo whether the branch exists and use
mainwhen it does not.2. The pull request workflows do not pass
TestResourceKeypublish.ymland the Publish job ofnightly-pipeline.ymlpassTestResourceKey, the pull request ones did not. Nobody noticed while the cloud tests were ignored. #178 turns them back on and they fail in setup with "A resource key is required to access the cloud server". The same secret is now passed inpull-requests.ymland in the PullRequests job ofnightly-pipeline.yml.ci/README.mdsays which examples branch is used.Notes
mainmerged in after this lands, then a new run. Re-running the old runs builds the old commit.Ubuntu_ARM_Java_17is red in those runs because it finishes first and the rest of the matrix is cancelled. It is not ARM specific.Tested
The branch check was run in PowerShell against the real examples repo: an existing branch, an existing branch with a slash in its name, two missing branches and a partial name. Both scripts parse and both workflow files are valid YAML. A full run needs CI.