Skip to content

CI: Fall back to main for examples and pass the resource key to pull request tests - #180

Merged
Automation51D merged 1 commit into
mainfrom
fix/pr-workflow-examples-branch-and-key
Sep 18, 2026
Merged

Automation51D merged 1 commit into
mainfrom
fix/pr-workflow-examples-branch-and-key

Conversation

@YaroslavVlasenko

Copy link
Copy Markdown
Contributor

Why:

The Pull Requests workflow fails on any branch that is not main. The three runs above show two separate causes, both in the CI setup.

1. Examples are cloned by the name of the branch under test

ci/run-integration-tests.ps1 and ci/run-performance-tests.ps1 clone ip-intelligence-java-examples with -Branch $Branch, and common-ci fills $Branch with the branch being tested. When the examples repo has no branch with that name the clone stops with:

fatal: Remote branch ci/dispatch-as-dry-run not found in upstream origin

Pairing branches by name was added on purpose in #67 and is kept. The scripts now ask the examples repo whether the branch exists and use main when it does not.

2. The pull request workflows do not pass TestResourceKey

publish.yml and the Publish job of nightly-pipeline.yml pass TestResourceKey, the pull request ones did not. Nobody noticed while the cloud tests were ignored. #178 turns them back on and they fail in setup with "A resource key is required to access the cloud server". The same secret is now passed in pull-requests.yml and in the PullRequests job of nightly-pipeline.yml.

ci/README.md says which examples branch is used.

Notes

Tested

The branch check was run in PowerShell against the real examples repo: an existing branch, an existing branch with a slash in its name, two missing branches and a partial name. Both scripts parse and both workflow files are valid YAML. A full run needs CI.

@YaroslavVlasenko
YaroslavVlasenko marked this pull request as draft September 17, 2026 18:53
@YaroslavVlasenko
YaroslavVlasenko marked this pull request as ready for review September 18, 2026 10:26
@Automation51D
Automation51D merged commit 5bf3406 into main Sep 18, 2026
32 of 77 checks passed
@Automation51D
Automation51D deleted the fix/pr-workflow-examples-branch-and-key branch September 18, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants