Repository navigation
Revert "feat: added p90 step time logic for GEMM and HBM tail latencies" - #136
Merged
Merged
Conversation
…es (AI-Hypercomputer#129)" This reverts commit 77c6dee.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request simplifies benchmark metric reporting by removing p10 and p90 statistics across several files, keeping only the median (p50) values. The reviewer feedback identifies a compatibility issue with Python versions older than 3.12 due to the use of double quotes inside double-quoted f-string expressions, and points out a missing space in the throughput formatting in benchmark_utils.py.
Comment on lines
+92
to
+93
| f"time taken (median): {time_statistics.statistics["p50"]:.4f} ms, " | ||
| f"bandwidth (median): {statistics.statistics["p50"]:.3f} GB/s" |
There was a problem hiding this comment.
Using double quotes inside a double-quoted f-string expression (e.g., statistics["p50"]) is only supported in Python 3.12+. For backward compatibility with Python < 3.12 (which is common in many ML environments), use single quotes for dictionary keys inside double-quoted f-strings.
Suggested change
| f"time taken (median): {time_statistics.statistics["p50"]:.4f} ms, " | |
| f"bandwidth (median): {statistics.statistics["p50"]:.3f} GB/s" | |
| f"time taken (median): {time_statistics.statistics['p50']:.4f} ms, " | |
| f"bandwidth (median): {statistics.statistics['p50']:.3f} GB/s" |
Comment on lines
+1291
to
+1299
| f"Total floating-point ops: {total_flops}, Step Time (median): " | ||
| f"{average_time_ms_statistics.statistics["p50"]:.2f}, " | ||
| f"Step Time (p90): " | ||
| f"{average_time_ms_statistics.statistics["p90"]:.2f}, " | ||
| f"Throughput (p10): " | ||
| f"{tflops_per_sec_statistics.statistics["p10"]:.2f}" | ||
| f" TFLOP / second / device, " | ||
| f"Throughput (median): " | ||
| f"{tflops_per_sec_statistics.statistics["p50"]:.2f}" | ||
| f" TFLOP / second / device, " | ||
| f"Throughput (p90): " | ||
| f"{tflops_per_sec_statistics.statistics["p90"]:.2f}" | ||
| f" TFLOP / second / device, " | ||
| f"TotalThroughput (p10): " | ||
| f"{tflops_per_sec_all_devices_statistics.statistics["p10"]:.2f} " | ||
| f"TFLOP / second, " | ||
| f"TotalThroughput (median): " | ||
| f"{tflops_per_sec_all_devices_statistics.statistics["p50"]:.2f} " | ||
| f"TFLOP / second, " | ||
| f"TotalThroughput (p90): " | ||
| f"{tflops_per_sec_all_devices_statistics.statistics["p90"]:.2f} " | ||
| f"TFLOP / second, " | ||
| f"MFU (p10): {mfu_statistics.statistics["p10"]:.2%}, " | ||
| f"MFU (median): {mfu_statistics.statistics["p50"]:.2%}, " | ||
| f"MFU (p90): {mfu_statistics.statistics["p90"]:.2%}" | ||
| f"MFU: {mfu_statistics.statistics["p50"]:.2%}" |
There was a problem hiding this comment.
Using double quotes inside a double-quoted f-string expression (e.g., statistics["p50"]) is only supported in Python 3.12+. For backward compatibility with Python < 3.12, use single quotes for dictionary keys inside double-quoted f-strings.
Suggested change
| f"Total floating-point ops: {total_flops}, Step Time (median): " | |
| f"{average_time_ms_statistics.statistics["p50"]:.2f}, " | |
| f"Step Time (p90): " | |
| f"{average_time_ms_statistics.statistics["p90"]:.2f}, " | |
| f"Throughput (p10): " | |
| f"{tflops_per_sec_statistics.statistics["p10"]:.2f}" | |
| f" TFLOP / second / device, " | |
| f"Throughput (median): " | |
| f"{tflops_per_sec_statistics.statistics["p50"]:.2f}" | |
| f" TFLOP / second / device, " | |
| f"Throughput (p90): " | |
| f"{tflops_per_sec_statistics.statistics["p90"]:.2f}" | |
| f" TFLOP / second / device, " | |
| f"TotalThroughput (p10): " | |
| f"{tflops_per_sec_all_devices_statistics.statistics["p10"]:.2f} " | |
| f"TFLOP / second, " | |
| f"TotalThroughput (median): " | |
| f"{tflops_per_sec_all_devices_statistics.statistics["p50"]:.2f} " | |
| f"TFLOP / second, " | |
| f"TotalThroughput (p90): " | |
| f"{tflops_per_sec_all_devices_statistics.statistics["p90"]:.2f} " | |
| f"TFLOP / second, " | |
| f"MFU (p10): {mfu_statistics.statistics["p10"]:.2%}, " | |
| f"MFU (median): {mfu_statistics.statistics["p50"]:.2%}, " | |
| f"MFU (p90): {mfu_statistics.statistics["p90"]:.2%}" | |
| f"MFU: {mfu_statistics.statistics["p50"]:.2%}" | |
| f"Total floating-point ops: {total_flops}, Step Time (median): " | |
| f"{average_time_ms_statistics.statistics['p50']:.2f}, " | |
| f"Throughput (median): " | |
| f"{tflops_per_sec_statistics.statistics['p50']:.2f}" | |
| f" TFLOP / second / device, " | |
| f"TotalThroughput (median): " | |
| f"{tflops_per_sec_all_devices_statistics.statistics['p50']:.2f} " | |
| f"TFLOP / second, " | |
| f"MFU: {mfu_statistics.statistics['p50']:.2%}" |
Comment on lines
+1376
to
1383
| f"Total bytes: {total_bytes}, Step Time (median): " | ||
| f"{average_time_ms_statistics.statistics["p50"]:.2f}, " | ||
| f"Step Time (p90): " | ||
| f"{average_time_ms_statistics.statistics["p90"]:.2f}, " | ||
| f"Throughput (p10): " | ||
| f"{gigabytes_per_sec_statistics.statistics["p10"]:.2f} " | ||
| f"GBytes / second / device, " | ||
| f"Throughput (median): " | ||
| f"Throughput (median):" | ||
| f"{gigabytes_per_sec_statistics.statistics["p50"]:.2f} " | ||
| f"GBytes / second / device, " | ||
| f"Throughput (p90): " | ||
| f"{gigabytes_per_sec_statistics.statistics["p90"]:.2f} " | ||
| f"GBytes / second / device, " | ||
| f"TotalThroughput (p10): " | ||
| f"{gigabytes_per_sec_all_devices_statistics.statistics["p10"]:.2f} " | ||
| f"GBytes / second, " | ||
| f"TotalThroughput (median): " | ||
| f"{gigabytes_per_sec_all_devices_statistics.statistics["p50"]:.2f} " | ||
| f"GBytes / second, " | ||
| f"TotalThroughput (p90): " | ||
| f"{gigabytes_per_sec_all_devices_statistics.statistics["p90"]:.2f} " | ||
| f"GBytes / second" |
There was a problem hiding this comment.
There are two issues here:
- Using double quotes inside a double-quoted f-string expression is only supported in Python 3.12+. Use single quotes for keys inside double-quoted f-strings for backward compatibility.
- There is a missing space after
Throughput (median):on line 1378, which will cause the printed output to be formatted incorrectly (e.g.,Throughput (median):123.45instead ofThroughput (median): 123.45).
Suggested change
| f"Total bytes: {total_bytes}, Step Time (median): " | |
| f"{average_time_ms_statistics.statistics["p50"]:.2f}, " | |
| f"Step Time (p90): " | |
| f"{average_time_ms_statistics.statistics["p90"]:.2f}, " | |
| f"Throughput (p10): " | |
| f"{gigabytes_per_sec_statistics.statistics["p10"]:.2f} " | |
| f"GBytes / second / device, " | |
| f"Throughput (median): " | |
| f"Throughput (median):" | |
| f"{gigabytes_per_sec_statistics.statistics["p50"]:.2f} " | |
| f"GBytes / second / device, " | |
| f"Throughput (p90): " | |
| f"{gigabytes_per_sec_statistics.statistics["p90"]:.2f} " | |
| f"GBytes / second / device, " | |
| f"TotalThroughput (p10): " | |
| f"{gigabytes_per_sec_all_devices_statistics.statistics["p10"]:.2f} " | |
| f"GBytes / second, " | |
| f"TotalThroughput (median): " | |
| f"{gigabytes_per_sec_all_devices_statistics.statistics["p50"]:.2f} " | |
| f"GBytes / second, " | |
| f"TotalThroughput (p90): " | |
| f"{gigabytes_per_sec_all_devices_statistics.statistics["p90"]:.2f} " | |
| f"GBytes / second" | |
| f"Total bytes: {total_bytes}, Step Time (median): " | |
| f"{average_time_ms_statistics.statistics['p50']:.2f}, " | |
| f"Throughput (median): " | |
| f"{gigabytes_per_sec_statistics.statistics['p50']:.2f} " | |
| f"GBytes / second / device, " | |
| f"TotalThroughput (median): " | |
| f"{gigabytes_per_sec_all_devices_statistics.statistics['p50']:.2f} " | |
| f"GBytes / second" |
Collaborator
|
The code change doesn't align with the PR title, could you double check? |
sarthakag
changed the title
Author
|
We will be rolling the PR forward in the next release of CHS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.