Conversation
Signed-off-by: Yusuf Efe <120668197+yuefdev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TFLite model reporter crashes on unmapped operators such as
CUSTOM,IF, andWHILEbecause the exception message mixes{}placeholders with%formatting. Format the message correctly so the existingValueErrorhandler can report unsupported operators and continue generating the supported-operator configuration.Also classify
ONE_HOTas unsupported instead of writing the literalUnsupportedinto the supported operators list and generated JSON.Validation:
python -m unittest discover -s python/tests -vpasses all 5 tests with the pinnedpython/requirements.txtdependencies on Python 3.10.21 / Windows x64. The tests fail on the original implementation and cover helper mappings plus subprocess CLI reporting using serialized TFLite metadata fixtures. No Arm inference or full C++ library build was run. Focused formatting, whitespace and license checks pass; the full pre-commit run encountered existing Windows tooling failures, addressed separately.