Conversation
Signed-off-by: Yusuf Efe <120668197+yuefdev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The model-reporting CLI prints a traceback when a model file is missing or its type cannot be identified.
identify_model_type()returnsNone,extract_model_meta()returns an empty tuple, and the caller tries to unpack four values.Reject unrecognized model types with
ArgumentParser.error()before extracting metadata. The command reports the offending path and exits nonzero without creating a partial build configuration or overwriting an existing one. Replace the nested deprecated logging call, which also emitted a strayWARNING:root:Noneline, with onelogging.warning()call.Validation:
python/requirements.txtdependencies. They cover missing, empty, unrecognized binary/text and directory inputs; mixed valid/invalid inputs in both orders; preservation of an existing configuration; and successful supported-model reporting. Before the fix, the invalid-input assertions failed while the supported-model control passed.main.This change handles files rejected by the existing model-type check. It does not add FlatBuffers structural validation for corrupt files that contain a TFLite signature.