Fix val_at returning the focus value for a dangling child - #106
Merged
luketpeterson merged 2 commits intoSep 17, 2026
Merged
Conversation
TrieRef lookups stepped into a child node even when that consumed the whole path, and an empty remaining path answers with the focus value. Only step into the child when path remains. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019R2H8fnco29asY2v3TPbtF
Collaborator
Author
|
https://github.com/Adam-Vandervorst/PathMap/actions/runs/35157988323#summary-105006282703 Benchmark: +27.3% binary_zipper_iter/50. doesn't seem to be noise, but doesn't affect overall benchmark results? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TrieRef lookups stepped into a child node even when that consumed the whole path, and an empty remaining path answers with the focus value. Only step into the child when path remains.