Fix sibling-step debug assert for a focus off the trie - #108
Merged
luketpeterson merged 2 commits intoSep 19, 2026
Merged
luketpeterson merged 2 commits into
luketpeterson merged 2 commits into
Conversation
With no sibling to move to, to_prev_sibling_byte restores the focus and returns None, then asserted path_exists(), which fails when the focus was never in the trie. Both sibling steps now assert the focus's existence is unchanged instead. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019R2H8fnco29asY2v3TPbtF
…ver-zealous debug_asserts. Lifting test up to macro.
luketpeterson
force-pushed
the
fix/prev-sibling-off-trie-assert
branch
from
September 19, 2026 07:31
9dd8c76 to
a3f2858
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With no sibling to move to, to_prev_sibling_byte restores the focus and returns None, then asserted path_exists(), which fails when the focus was never in the trie. Both sibling steps now assert the focus's existence is unchanged instead.