Fix ACTZipper sibling steps and ascend_until off the trie - #113
Merged
luketpeterson merged 2 commits intoSep 19, 2026
Merged
Conversation
imlvts
marked this pull request as draft
September 19, 2026 06:26
Collaborator
Author
|
To be changed: #111 includes the fix for sibling movement, separate sibling step |
to_sibling answered None for a focus one byte off the trie, so to_next_step gave up instead of moving to the next sibling. ascend_until then checked the landing node rather than the focus for a value or branch, stopping at the wrong ancestor.
imlvts
force-pushed
the
fix/act-off-trie-focus
branch
from
September 19, 2026 08:18
0ebe97a to
ef95f43
Compare
imlvts
marked this pull request as ready for review
September 19, 2026 08:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to_sibling answered None for a focus one byte off the trie, so to_next_step gave up instead of moving to the next sibling. ascend_until then checked the landing node rather than the focus for a value or branch, stopping at the wrong ancestor.