Repository navigation
feat(studio): a Settings panel in the device pane for dark mode, font size, language, orientation and deep links - #461
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0122FvtGQmjNf8YsduMLvZLh
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0122FvtGQmjNf8YsduMLvZLh
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0122FvtGQmjNf8YsduMLvZLh
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0122FvtGQmjNf8YsduMLvZLh
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0122FvtGQmjNf8YsduMLvZLh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Studio's device pane gets a Settings button. Its panel changes OS-level settings of the connected emulator or simulator: appearance, font size, app language, orientation (Android) and opening a deep link. It uses the
internal/devsettingspackage added withprobe device set, so the allowed values and the quoting are the same as on the command line and in the MCP tool.project.appfromprobe.yaml.studio/devicesettings.go(+ test),studio/frontend/src/device-settings.ts; the header button, the panel container, a little CSS and the Wails bindings are the only edits to existing files.This is stacked on the
probe device setPR and is retargeted tomainonce that merges.Test plan
tsc --noEmitandnpm run buildfor the Studio frontendsimctl, then restored); the simulator was shut down afterwardsstudio/README.mdupdatedprobe device setruns, not by a Studio browser test