Repository navigation
Conversation
The interface journal skipped struct, structarray and basicarray parameters, so calls such as SetExtent were recorded without values. - Serialize struct parameters and results as <member> child elements, including enum and fixed-size array members. - Serialize basicarray and structarray parameters and results as <item> child elements with a count attribute (at most 1000 items per array). - XML-escape attribute values so string values such as WKT keep the journal well-formed. - Write single and double values with full significant digits. - Label int32 values as int32 instead of uint32. - Use the component base name casing for the journal file names and includes, matching the other interface files. Co-authored-by: Cursor <cursoragent@cursor.com>
…en failures Entries hold a shared reference to their journal, so a journal that SetJournal replaces stays open until in-flight calls finish. A mutex guards the global journal pointer. The journal constructor throws INVALIDPARAM when the file cannot be opened. Co-authored-by: Cursor <cursoragent@cursor.com>
gangatp
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The interface journal skipped struct, structarray and basicarray parameters, so calls such as SetExtent were recorded without values.