Repository navigation
Read the conditions once in AlwaysReturnInFilter's isInsideIfConditonal() - #905
Merged
GaryJones merged 1 commit intoOct 9, 2026
Conversation
The guard for a missing conditions array came after two end() calls that had already read it. PHP_CodeSniffer sets conditions on every token, so the guard goes. Working on a copy also removes the need for reset(), which was there to undo end() moving the pointer on the shared token array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A tidy-up @GaryJones spotted while reviewing #901. It does not change what the sniff reports.
The guard for a missing
conditionsarray ran after the array had already been read, and PHP_CodeSniffer setsconditionson every token anyway, so the guard is gone.Fixes #903