Repository navigation
chore: port-to-v6 rolling port - #25591
Merged
Merged
Conversation
. (cherry picked from commit 86d0021)
IlyasRidhuan
marked this pull request as ready for review
October 5, 2026 11:43
IlyasRidhuan
requested review from
IlyasRidhuan,
LeilaWang,
iAmMichaelConnor,
iakovenkos,
just-mitch,
koenmtb1 and
ledwards2225
as code owners
October 5, 2026 11:43
IlyasRidhuan
enabled auto-merge
October 5, 2026 11:43
IlyasRidhuan
approved these changes
Oct 5, 2026
Binding checkpoint boundaries into the blob commitments hash changes the rollup circuits, so the VK tree root v6 builds moves to 0x031139abb5b9f51ca0e55a6e2022d567029f50acc9428506f05c91ae27e7f75d. Labs patch 0001 pins testnet_compatibility.test.ts to it; the protocol contracts hash and genesis root are unchanged.
IlyasRidhuan
disabled auto-merge
October 5, 2026 12:30
iakovenkos
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rolling integration PR for changes labelled
port-to-v6onnext. Each merged source PR is cherry-picked ontocb/port-to-v6as its own commit, keeping(#N)in the title.Ported
-m 1, applied without conflicts, plus onefix(port)commit)nextat 86d0021, as do theblobandrollup-libcrates and the wholel1-contractsdirectory.nextnumbering:0006-fix-blob-lib-bind-checkpoint-boundaries-into-the-blo.patch(yarn-project/blob-lib, a test fixture path and the L1 publisher integration test)0007-docs-aztec-nr-private-log-fields-past-the-log-s-leng.patch(a doc comment inaztec-nr'sprivate_context.nr)v6labs pina0d73c0aedas the patch expects.fix(port)commit updates labs patch0001-test-pin-testnet-compatibility-to-the-v6-kernel-VK-t.patchto the VK tree rootv6builds with this change.Protocol impact
0x01for a checkpoint's first blob and0x00otherwise. The change is made in three places that have to agree:BlobLib.calculateBlobCommitmentsHashblobcrate (blob_batching.nr, the accumulator ABIs), consumed by the rollup circuitsyarn-project/blob-lib, through labs patch 0006v6builds moves:0x1032cbb2f61a9c1151370ebc35c8ea20d1a726e3388eb94e84291c2b2fecb5d3(pinned onv6since chore: port-to-v6 rolling port #25587)0x031139abb5b9f51ca0e55a6e2022d567029f50acc9428506f05c91ae27e7f75d(taken from this PR's failing CI run onb2cd9f3f), which is what labs patch 0001 now pinsv6has root0x2d89003cc2dc62b06f07d83d3635c66c63fc43668369d30e7ee516f908ee10e3;v6has not matched it since chore: port-to-v6 rolling port #25575. The re-pin follows the decision recorded on chore: port-to-v6 rolling port #25549 (a breaking circuit change ported tov6re-pins testnet in the same PR).b2cd9f3f.Testing
b2cd9f3f(before the re-pin):testnet_compatibility.test.ts› "has expected VK tree root" was the only failure in the fast run, which covers thebloband rollup circuit tests, the newblobCommitmentsHash.t.solforge test and the labsblob-libtests../labs-patches/bootstrap.sh check: the series (0001, 0006, 0007, 0010) applies cleanly to the labs pina0d73c0aed. Patch 0001 was produced withbootstrap.sh apply/export.nargoand no pinnedsolcin the port environment); the re-pinned test runs on this PR's CI.Created by claudebox · group:
slackbot· Slack thread