Repository navigation
test(e2e): remove host SSH unit tests - #9815
Merged
Artur Khantimirov (r2k1) merged 2 commits intoOct 18, 2026
Merged
Conversation
Remove TestScriptUploadBytesAndUniqueFiles after its Windows case timed out in build 186406867. Keep the blocked-transfer deadline test and leave runtime upload behavior unchanged. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7ea77dab-f80c-4510-ac31-5c67efe52a7f
Contributor
Windows Unit Test Results 3 files 18 suites 1m 9s ⏱️ Results for commit f6764fd. ♻️ This comment has been updated with latest results. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The test-only deletion matches the stated scope and introduces no identified functional issues.
No open issues 🎉
What changed in this PR
Removes the SSH upload test that blocked the unit suite, without changing runtime upload behavior or its timeout.
Changes:
- Deletes
TestScriptUploadBytesAndUniqueFiles, including Linux and Windows cases. - Removes unused imports and retains
TestScriptUploadDeadlineClosesBlockedTransfer.
| File | Description |
|---|---|
| e2e/scenario/ssh_upload_test.go | Removes the byte-preservation and filename-uniqueness test while retaining deadline coverage. |
Review effort: Balanced
Remove unit tests that open SSH connections or loopback Bastion listeners. Retain pure retry, error classification, and mocked transport tests. Leave runtime and E2E scenario behavior unchanged. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7ea77dab-f80c-4510-ac31-5c67efe52a7f
Artur Khantimirov (r2k1)
changed the title
Contributor
|
Contributor
|
Tim Wright (timmy-wright)
approved these changes
Oct 18, 2026
Contributor
|
Artur Khantimirov (r2k1)
deleted the
r2k1-build-failure-investigation-9db
branch
October 18, 2026 22:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Remove unit tests that open host SSH connections or loopback Bastion listeners; leave connection coverage to E2E tests. Keep pure retry, error-classification, and mocked-transport tests. Runtime code is unchanged.
Validation:
cd e2e && go test ./scenario -count=1 -timeout=120s— passed.Which issue(s) this PR fixes:
N/A