Skip to content

[AutoPR azure-mgmt-dataprotection]-generated-from-SDK Generation - Python-6788511 - #48901

Open
azure-sdk-automation[bot] wants to merge 1 commit into
mainfrom
sdkauto/azure-mgmt-dataprotection-6788511
Open

[AutoPR azure-mgmt-dataprotection]-generated-from-SDK Generation - Python-6788511#48901
azure-sdk-automation[bot] wants to merge 1 commit into
mainfrom
sdkauto/azure-mgmt-dataprotection-6788511

Conversation

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

Configurations: 'specification/dataprotection/resource-manager/Microsoft.DataProtection/DataProtection/tspconfig.yaml', and CommitSHA: '4f774bdae44fac19491a1caa4ec91760d9bf9b1b' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6788511 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releaseplan=35661 Submitted by:

Copilot AI balanced review requested due to automatic review settings September 4, 2026 04:10
@azure-sdk-automation azure-sdk-automation Bot added the auto-release When merged to main, release pipelines for this PR's changed packages trigger automatically. label Sep 4, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
10 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new validation incorrectly blocks the existing resume-protection operation for clients pinned to the previously supported 2026-03-01 API version.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Regenerates azure-mgmt-dataprotection for API version 2026-06-01 and prepares stable release 2.2.0.

Changes:

  • Adds cost-management and generic backup/restore models.
  • Updates generated operations, tests, samples, and API metadata.
  • Advances the package version and specification commit.
File summaries
File Description
tsp-location.yaml Updates the specification commit.
generated_tests/test_data_protection_mgmt_backup_vaults_operations.py Adds cost-management request data.
generated_tests/test_data_protection_mgmt_backup_vaults_operations_async.py Adds asynchronous cost-management request data.
generated_samples/validate_restore.py Updates sample API provenance.
generated_samples/validate_for_modify_backup.py Updates sample API provenance.
generated_samples/validate_for_backup.py Updates sample API provenance.
generated_samples/validate_cross_region_restore.py Updates sample API provenance.
generated_samples/unlock_delete_resource_guard_proxy.py Updates sample API provenance.
generated_samples/undelete_deleted_backup_instance.py Updates sample API provenance.
generated_samples/trigger_restore.py Updates sample API provenance.
generated_samples/trigger_restore_with_rehydration.py Updates sample API provenance.
generated_samples/trigger_restore_with_generic_parameters.py Adds a generic restore sample.
generated_samples/trigger_restore_as_files.py Updates sample API provenance.
generated_samples/trigger_rehydrate.py Updates sample API provenance.
generated_samples/trigger_export_jobs.py Updates sample API provenance.
generated_samples/trigger_cross_region_restore.py Updates sample API provenance.
generated_samples/trigger_backup.py Updates sample API provenance.
generated_samples/sync_backup_instance.py Updates sample API provenance.
generated_samples/suspend_backups.py Updates sample API provenance.
generated_samples/suspend_backup_resource_guard_enabled.py Updates sample API provenance.
generated_samples/stop_protection.py Updates sample API provenance.
generated_samples/stop_protection_resource_guard_enabled.py Updates sample API provenance.
generated_samples/resume_protection.py Updates sample API provenance.
generated_samples/resume_backups.py Updates sample API provenance.
generated_samples/put_resource_guard.py Updates sample API provenance.
generated_samples/put_resource_guard_proxy.py Updates sample API provenance.
generated_samples/put_backup_vault.py Updates sample API provenance.
generated_samples/put_backup_vault_with_undelete.py Updates sample API provenance.
generated_samples/put_backup_vault_with_msi.py Updates sample API provenance.
generated_samples/put_backup_vault_with_cost_management_settings.py Adds a cost-management creation sample.
generated_samples/put_backup_vault_with_cmk.py Updates sample API provenance.
generated_samples/put_backup_vault_cmk_settings_resource_guard_enabled.py Updates sample API provenance.
generated_samples/put_backup_instance.py Updates sample API provenance.
generated_samples/put_backup_instance_with_generic_parameters.py Adds a generic backup sample.
generated_samples/put_backup_instance_resource_guard_enabled.py Updates sample API provenance.
generated_samples/put_backup_instance_kubernetes_cluster_backup_datasource_parameters.py Updates sample API provenance.
generated_samples/put_backup_instance_blob_backup_auto_protection.py Updates sample API provenance.
generated_samples/put_backup_instance_adlsblob_backup_datasource_parameters.py Updates sample API provenance.
generated_samples/put_backup_instance_adlsblob_backup_auto_protection.py Updates sample API provenance.
generated_samples/patch_resource_guard.py Updates sample API provenance.
generated_samples/patch_backup_vault.py Updates sample API provenance.
generated_samples/patch_backup_vault_with_cost_management_settings.py Adds a cost-management update sample.
generated_samples/patch_backup_vault_with_cmk.py Updates sample API provenance.
generated_samples/list.py Updates sample API provenance.
generated_samples/list_update_protection_policy_requests.py Updates sample API provenance.
generated_samples/list_update_protected_item_requests.py Updates sample API provenance.
generated_samples/list_resource_guard_proxy.py Updates sample API provenance.
generated_samples/list_recovery_points.py Updates sample API provenance.
generated_samples/list_jobs.py Updates sample API provenance.
generated_samples/list_disable_soft_delete_requests.py Updates sample API provenance.
generated_samples/list_deleted_backup_instances.py Updates sample API provenance.
generated_samples/list_delete_resource_guard_proxy_requests.py Updates sample API provenance.
generated_samples/list_delete_protected_item_requests.py Updates sample API provenance.
generated_samples/list_backup_security_pin_requests.py Updates sample API provenance.
generated_samples/list_backup_policy.py Updates sample API provenance.
generated_samples/list_backup_instances.py Updates sample API provenance.
generated_samples/list_backup_instances_extension_routing.py Updates sample API provenance.
generated_samples/get_resource_guards_in_subscription.py Updates sample API provenance.
generated_samples/get_resource_guards_in_resource_group.py Updates sample API provenance.
generated_samples/get_resource_guard.py Updates sample API provenance.
generated_samples/get_resource_guard_proxy.py Updates sample API provenance.
generated_samples/get_recovery_point.py Updates sample API provenance.
generated_samples/get_operation_status.py Updates sample API provenance.
generated_samples/get_operation_status_vault_context.py Updates sample API provenance.
generated_samples/get_operation_status_rg_context.py Updates sample API provenance.
generated_samples/get_operation_result.py Updates sample API provenance.
generated_samples/get_operation_result_patch.py Updates sample API provenance.
generated_samples/get_job.py Updates sample API provenance.
generated_samples/get_export_jobs_operation_result.py Updates sample API provenance.
generated_samples/get_deleted_backup_instance.py Updates sample API provenance.
generated_samples/get_default_update_protection_policy_requests.py Updates sample API provenance.
generated_samples/get_default_update_protected_item_requests.py Updates sample API provenance.
generated_samples/get_default_disable_soft_delete_requests.py Updates sample API provenance.
generated_samples/get_default_delete_resource_guard_proxy_requests.py Updates sample API provenance.
generated_samples/get_default_delete_protected_item_requests.py Updates sample API provenance.
generated_samples/get_default_backup_security_pin_requests.py Updates sample API provenance.
generated_samples/get_backup_vaults_in_subscription.py Updates sample API provenance.
generated_samples/get_backup_vaults_in_resource_group.py Updates sample API provenance.
generated_samples/get_backup_vault.py Updates sample API provenance.
generated_samples/get_backup_vault_with_msi.py Updates sample API provenance.
generated_samples/get_backup_vault_with_cost_management_settings.py Adds a cost-management retrieval sample.
generated_samples/get_backup_vault_with_cmk.py Updates sample API provenance.
generated_samples/get_backup_policy.py Updates sample API provenance.
generated_samples/get_backup_instance.py Updates sample API provenance.
generated_samples/get_backup_instance_operation_result.py Updates sample API provenance.
generated_samples/get_backup_instance_blob_backup_auto_protection.py Updates sample API provenance.
generated_samples/get_backup_instance_adlsblob_backup_datasource_parameters.py Updates sample API provenance.
generated_samples/get_backup_instance_adlsblob_backup_auto_protection.py Updates sample API provenance.
generated_samples/find_restorable_time_ranges.py Updates sample API provenance.
generated_samples/fetch_secondary_rps.py Updates sample API provenance.
generated_samples/fetch_cross_region_restore_jobs.py Updates sample API provenance.
generated_samples/fetch_cross_region_restore_job.py Updates sample API provenance.
generated_samples/deleted_backup_vaults_list_by_location.py Updates sample API provenance.
generated_samples/deleted_backup_vaults_get.py Updates sample API provenance.
generated_samples/delete_resource_guard.py Updates sample API provenance.
generated_samples/delete_resource_guard_proxy.py Updates sample API provenance.
generated_samples/delete_backup_vault.py Updates sample API provenance.
generated_samples/delete_backup_policy.py Updates sample API provenance.
generated_samples/delete_backup_instance.py Updates sample API provenance.
generated_samples/create_or_update_backup_policy.py Updates sample API provenance.
generated_samples/checkfeature_support.py Updates sample API provenance.
generated_samples/check_backup_vaults_name_availability.py Updates sample API provenance.
CHANGELOG.md Documents release 2.2.0.
operations/_patch.py Applies generated formatting cleanup.
operations/_operations.py Regenerates synchronous operations.
models/_patch.py Applies generated formatting cleanup.
models/_enums.py Adds GranularityLevel.
models/__init__.py Exports the new public models.
aio/operations/_patch.py Applies generated formatting cleanup.
aio/operations/_operations.py Regenerates asynchronous operations.
aio/_patch.py Applies generated formatting cleanup.
aio/_configuration.py Updates the asynchronous API version.
aio/_client.py Updates asynchronous client documentation.
_version.py Advances the package to 2.2.0.
_utils/serialization.py Expands serializer documentation.
_utils/model_base.py Updates generated deserialization utilities.
_patch.py Applies generated formatting cleanup.
_configuration.py Updates the synchronous API version.
_client.py Updates synchronous client documentation.
apiview-properties.json Maps the newly exposed API types.
api.metadata.yml Updates API artifact metadata.
api.md Records the regenerated public API surface.
_metadata.json Records the new API and generator versions.
Review details

Suppressed comments (1)

sdk/dataprotection/azure-mgmt-dataprotection/api.md:4901

  • This marks begin_resume_protection as introduced only in 2026-06-01, although the operation has been public since 1.0.0b2 (CHANGELOG.md:233-235) and was available with the previous 2026-03-01 default. The validator will now raise ValueError for clients pinned to 2026-03-01 before sending the request, which is a breaking regression in this minor release. Preserve the earlier supported API versions and regenerate the synchronous surface instead of restricting the method to 2026-06-01.
        @api_version_validation(method_added_on='2026-06-01', params_added_on={'2026-06-01': ['api_version', 'subscription_id', 'resource_group_name', 'vault_name', 'backup_instance_name']}, api_versions_list=['2026-06-01'])
  • Files reviewed: 124/125 changed files
  • Comments generated: 1
  • Review effort level: Balanced

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread sdk/dataprotection/azure-mgmt-dataprotection/api.md
@ChenxiJiang333 ChenxiJiang333 added the mgmt-review-needed PR for Mgmt SDK is ready to review label Sep 7, 2026
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Management SDK PR review

Findings: None.

Unverified checks

Unverified checks: None.

Review summary

Package reviewed: sdk/dataprotection/azure-mgmt-dataprotection

Checks completed:

  • API version drift: _metadata.json apiVersion unchanged (2026-06-01 at both first and latest revision d9041abeec74e1bcdd0e9c5ca5549d17d1da2d98).
  • Version consistency: _version.py (2.2.0) matches the latest CHANGELOG.md entry (## 2.2.0 (2026-09-04)).
  • Preview API version / SDK version alignment: apiVersion is stable (no preview), and package version 2.2.0 is a stable version (no b) — consistent.
  • Changelog date: release date 2026-09-04 is not more than 3 weeks in the future — no reminder needed.
  • pyproject.toml stability flags: is_stable = true and classifiers include "Development Status :: 5 - Production/Stable", correctly matching the stable 2.2.0 version.
  • Client signature: _client.py's DataProtectionMgmtClient.__init__ has credential, subscription_id, base_url in the required order.
  • Client name consistency: DataProtectionMgmtClient matches across _client.py, README.md, and pyproject.toml title.
  • README code snippets: Authentication sample uses credential and subscription_id consistent with the actual client signature.

No violations of the MGMT SDK Code Review Rules were found for this package.

@ChenxiJiang333

Copy link
Copy Markdown
Member

Hi, SDK PR has been approved. You can move on to merge and release through the action suggestion in Release Plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-release When merged to main, release pipelines for this PR's changed packages trigger automatically. mgmt-review-needed PR for Mgmt SDK is ready to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants