feat: memory consolidation step 1 — pending_review age expiry (B4) - #244
Merged
Merged
Conversation
…e-trim - UserStatePendingMaxAgeDays is *int now: explicit JSON 0 disables expiry (a plain int with a != 0 Resolve guard made 0 unreachable — MAJOR finding confirmed by all three judges); nil = default 14 - age expiry runs BEFORE the maxPending count trim so a stale entry can no longer evict a fresh one from a cap slot - TestResolve_ZeroAgeDisables pins the JSON->Resolve->disable contract
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
user_state_pending_max_age_days(*int, default 14, explicit 0 = never expire):applyDiffprunes unconfirmed entries older than the window, BEFORE the count trim so stale entries can't evict fresh ones.Review-found fixes (3-judge panel)
!= 0Resolve guard made the documented '0 disables' unreachable; field is *int now with a JSON→Resolve→disable contract test.Test plan