Restore dart pub publish in the publish jobs - #531
Merged
Merged
Conversation
Installing the Flutter SDK was the actual fix for the failed v3.4.3 and firebase-v2.1.4 runs; switching the command to `flutter pub publish` was an unrelated change bundled into it. flutter-action sets FLUTTER_ROOT, which is what lets pub resolve the `flutter` SDK dependency, so `dart pub publish` works and keeps these jobs in line with dart.dev's automated publishing documentation. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Follow-up to #530, narrowing that change to what the fix actually required.
#530 both installed the Flutter SDK in the publish jobs and switched the command to
flutter pub publish -f. Only the SDK setup was needed; the command swap was an unrelated change that also moved these jobs away from the command shown in dart.dev's automated publishing documentation.🆕 What is the new behavior (if this is a feature change)?
The publish command is
dart pub publish -v -fagain.subosito/flutter-actionsetsFLUTTER_ROOT, which is how pub locates the Flutter SDK to resolve theflutterSDK dependency, so the Dart command resolves and publishes correctly.💥 Does this PR introduce a breaking change?
No.
🐛 Recommendations for testing
Not exercised by PR checks — the publish jobs only run on a tag push. Verified by re-pointing the
v3.4.3/firebase-v2.1.4tags at this commit and confirming both packages reach pub.dev.📝 Links to relevant issues/docs
Follow-up to #530. Automated publishing.
🤔 Checklist before submitting
🤖 Generated with Claude Code