Repository navigation
Name the forbidden character in the port name error - #1223
Merged
facontidavide merged 1 commit intoOct 3, 2026
Merged
facontidavide merged 1 commit into
facontidavide merged 1 commit into
Conversation
…ee#1221) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
|
thanks |
imere
added a commit
to imere/BehaviorTree.TS
that referenced
this pull request
Oct 5, 2026
Upstream: BehaviorTree/BehaviorTree.CPP#1221 Title: Name the forbidden character in the port name error (fixes BehaviorTree/BehaviorTree.CPP#1221) (BehaviorTree/BehaviorTree.CPP#1223) The message interpolated the forbid patterns themselves, so a bad port name produced something like "must not be [,/^[^a-z]/i]" and never showed what was actually wrong. It now names the offending name and character.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1221.
CreatePortnow names the character when a port name contains one of the characters rejected since 4.8.4, using the same wording as the XML path:Other invalid names, such as
name,IDor a leading_or digit, still get the existing message.To share the wording,
formatForbiddenCharmoves from the anonymous namespace inxml_parsing.cpptobasic_types.h/.cpp, next tofindForbiddenChar.CreatePortis defined in the header and needs it. This adds one public function and changes no existing signature.NameValidation.CreatePort_NamesForbiddenCharcovers a printable character and a control character. It fails on master and passes with this change. The full suite passes, and so does pre-commit.🤖 Generated with Claude Code