Conversation
esp_tinyusb 2.x validates the task settings passed to
tinyusb_driver_install(), so the zero-initialised config is now rejected
("Task size can't be 0"): serial_init() fails and every ESP32-S3 build
using TinyUSB aborts at boot. Use TINYUSB_DEFAULT_CONFIG() instead.
Collaborator
|
Merged (with rebase) - thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the update to IDF v5.5.5 (esp_tinyusb 2.2.1), ESP32-S3 builds that use TinyUSB don't boot: they stop on the splash screen.
esp_tinyusb 2.x checks the task settings in the config passed to tinyusb_driver_install(), and the zero-initialised config fails that check ("Task size can't be 0"). serial_init() then returns false and main.c aborts.
This uses TINYUSB_DEFAULT_CONFIG() instead.
From reading the code this should affect every S3 config that uses TinyUSB (i.e. without CONFIG_JADE_USE_USB_JTAG_SERIAL), since the check only looks at the config struct, but I've only tested it on the two Waveshare boards below.
Tested on a Waveshare Touch LCD 2 with current master: without the fix it stops on the splash screen, with the fix it boots to the home screen and shows up as 303a:4001. Same result on the Touch LCD 3.5 (#330).