Skip to content

release.yml: pass the tag through env instead of interpolating it into shell #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bogzx merged 1 commit into from
Oct 1, 2026
Merged

release.yml: pass the tag through env instead of interpolating it into shell #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,17 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
persist-credentials: false
- uses: actions/setup-python@v5
with:
python-version: "3.13"
- name: Tag matches __version__ and has a dated CHANGELOG entry
run: python scripts/check_release.py "${{ github.event.release.tag_name }}"
# Event data goes through env, never into the script text: a tag name is
# user-controlled and could otherwise inject shell.
env:
TAG: ${{ github.event.release.tag_name }}
run: python scripts/check_release.py "$TAG"
- run: pip install build twine && python -m build
- run: twine check --strict dist/*
- name: Test the sdist
Expand Down Expand Up @@ -50,7 +56,9 @@ jobs:
- name: Attach the sdist and wheel to the release
env:
GH_TOKEN: ${{ github.token }}
run: gh release upload "${{ github.event.release.tag_name }}" dist/* --repo "${{ github.repository }}"
TAG: ${{ github.event.release.tag_name }}
REPO: ${{ github.repository }}
run: gh release upload "$TAG" dist/* --repo "$REPO"

publish-testpypi:
needs: build
Expand Down
Loading