fix: recover exports when macOS save panels are unavailable - #2247
Open
richiemcilroy wants to merge 1 commit into
Open
fix: recover exports when macOS save panels are unavailable#2247richiemcilroy wants to merge 1 commit into
richiemcilroy wants to merge 1 commit into
Conversation
Member
Author
|
hey @greptileai, please re-review the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macOS can return a nil
NSSavePanel, which previously panicked inside rfd on the main thread and froze Studio export. Use a nil-safe asynchronous AppKit save dialog for Tauri and distinguish native dialog failures from cancellation in GPUI. When a Studio save dialog fails, finish rendering to the existing project output and return that path to the completion UI. Explicit Cancel still cancels.Route screenshot and SRT/VTT caption saves through the safe command too. Grant filesystem access to the selected path on every platform so these callers retain their existing write permissions. Windows/Linux keep their existing native dialog implementation.
Fixes #2163.
Validation:
cargo clippy -p cap-desktop --lib -- -D warnings.The packaged app still needs a smoke test on the reporter's macOS 26.3 environment, including save, cancel, fallback output, and playback. Native injection ran in a standalone process on macOS 27 arm64. Windows/Linux runtime behavior was reviewed, not exercised here. The isolated GPUI compile check is blocked by the existing checked-in lockfile versus local patched Zed dependencies; the current v0.6 working-tree GPUI check passed with Rust 1.95. This PR changes no GPUI manifest or lockfile.
The PR appears safe to merge, with cancellation, native-dialog failure, selected destinations, and fallback outputs remaining distinct throughout the export flows.
Summary