Make single-target local builds opt-in - #10359
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change cleanly separates single-target builds behind an explicit opt-in flag, with only a minor wording nit identified.
Pull request overview
Adjusts local-development build behavior so that building only a single target framework is an explicit opt-in, while keeping other “local dev” MSBuild tweaks available independently.
Changes:
- Split the “single-target framework” MSBuild behavior behind a new opt-in flag (
DOTNET_LOCAL_DEV_SINGLE_TARGET_FRAMEWORK). - Update the backend devcontainer environment to default single-target builds to off while keeping
DOTNET_LOCAL_DEVconfigurable.
File summaries
| File | Description |
|---|---|
| src/Directory.Build.props | Renames the MSBuild condition controlling single-target local builds to a dedicated opt-in property. |
| .devcontainer/backend/devcontainer.json | Passes through/sets local-dev env vars, defaulting single-target builds to disabled. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.