ci: add memtrack walltime benchmarks to CI - #537
Open
not-matthias wants to merge 3 commits into
Open
not-matthias wants to merge 3 commits into
not-matthias wants to merge 3 commits into
Conversation
Merging this PR will not alter performance
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| 🆕 | WallTime | memtrack track dd |
N/A | 1.3 s | N/A |
| 🆕 | WallTime | memtrack track ls |
N/A | 1.1 s | N/A |
| 🆕 | WallTime | memtrack track tar |
N/A | 9.6 s | N/A |
| 🆕 | WallTime | memtrack track dd (with physical) |
N/A | 1.5 s | N/A |
| 🆕 | WallTime | memtrack track ls (with physical) |
N/A | 1.3 s | N/A |
| 🆕 | WallTime | memtrack track tar (with physical) |
N/A | 9.7 s | N/A |
| 🆕 | Memory | memtrack track dd |
N/A | 51 MB | N/A |
| 🆕 | Memory | memtrack track ls |
N/A | 50.9 MB | N/A |
| 🆕 | Memory | memtrack track tar |
N/A | 50.6 MB | N/A |
| 🆕 | Memory | memtrack track dd (with physical) |
N/A | 51.1 MB | N/A |
| 🆕 | Memory | memtrack track ls (with physical) |
N/A | 51 MB | N/A |
| 🆕 | Memory | memtrack track tar (with physical) |
N/A | 50.9 MB | N/A |
| 🆕 | WallTime | encode_events_via_batched_channel |
N/A | 151.7 ms | N/A |
| 🆕 | WallTime | encode_events_via_channel |
N/A | 296.9 ms | N/A |
| 🆕 | WallTime | encode_events_worker_scaling[1] |
N/A | 640.3 ms | N/A |
| 🆕 | WallTime | encode_events_worker_scaling[2] |
N/A | 362.5 ms | N/A |
| 🆕 | WallTime | encode_events_worker_scaling[4] |
N/A | 215.3 ms | N/A |
| 🆕 | WallTime | encode_events_worker_scaling[8] |
N/A | 140.9 ms | N/A |
| 🆕 | Simulation | encode_events_via_batched_channel |
N/A | 1.3 s | N/A |
| 🆕 | Simulation | encode_events_via_channel |
N/A | 1.4 s | N/A |
| ... | ... | ... | ... | ... | ... |
ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.
Comparing cod-3093-memtrack-data-format-improvements (829da2f) with main (f198706)
not-matthias
force-pushed
the
cod-3093-memtrack-data-format-improvements
branch
2 times, most recently
from
September 16, 2026 10:29
596e932 to
5f67554
Compare
not-matthias
changed the base branch from
main
to
cod-3492-memtrack-classic-tracepoints-cannot-attach-inside-the
September 16, 2026 10:29
Base automatically changed from
cod-3492-memtrack-classic-tracepoints-cannot-attach-inside-the
to
main
September 16, 2026 10:49
not-matthias
force-pushed
the
cod-3093-memtrack-data-format-improvements
branch
2 times, most recently
from
September 16, 2026 14:49
b7adccd to
3efb21e
Compare
not-matthias
marked this pull request as ready for review
September 16, 2026 14:51
|
The poll thread sent one item per channel message, and std's mpsc allocates a 31-slot block per 31 messages, so a run that captured 704k events also allocated 22.7k blocks purely to hand them over. The callback now fills a shared 1024-item buffer and sends it whole. Partial batches are flushed after every poll, after the drain-path consume before its ack, and on the shutdown consume, so `drain()` keeps promising that all pending entries sit in the channel once it returns. Consumers take `Vec<T>` and flatten: the encode pipeline keeps its `IntoIterator<Item = MemtrackEvent>` contract unchanged.
The encoder benches fed `encode_events` from a Vec, while production feeds it an mpsc receiver, so the channel the events actually arrive through was absent from the benchmarks. Adds a per-event and a batched channel bench that differ only in batching, plus a worker sweep bounded by the core count, since asking for more workers than pinned cores measures oversubscription rather than scaling.
not-matthias
force-pushed
the
cod-3093-memtrack-data-format-improvements
branch
from
September 16, 2026 16:17
21ce920 to
829da2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
memtrack-benchmarksCI job that runscodspeed-memtrack trackagainst a few representative workloads (ls,dd,tar), each with RSS-only and RSS+rmap variants, to catch regressions in memtrack's own overhead.Runs both
walltime(execution time) andmemory(memtrack's own peak RSS/allocations while tracking each workload) modes against the samecrates/memtrack/codspeed.ymlconfig.