Repository navigation
Conversation
Capstone is compiled for the primary platform only, and cycledecode.c does not build without it. On a bi-arch host with 32-bit multilib, a plain ./configure also enabled the secondary x86 Callgrind, which then failed in make with a missing capstone/capstone.h and the CLG_WITH_CAPSTONE #error. Default to --enable-only64bit unless --enable-only64bit or --enable-only32bit was given either way, and fail at configure time with a clear message if a secondary platform is still requested. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
| # used. --njn] | ||
|
|
||
| # CodSpeed: 64-bit only by default. See m4/codspeed_capstone.m4. | ||
| CODSPEED_ONLY64BIT_DEFAULT |
There was a problem hiding this comment.
Default lacks CI coverage Both CI builds pass
--enable-only64bit, so neither tests what happens when ./configure receives no architecture flag. If the new default stops selecting a single platform, CI could pass while a plain build fails when the secondary Callgrind target compiles without Capstone. Please add a test that configures without either architecture flag and checks that no secondary platform is selected.
Prompt To Fix With AI
This is a comment left during a code review.
Path: configure.ac
Line: 336
Comment:
**Default lacks CI coverage** Both CI builds pass `--enable-only64bit`, so neither tests what happens when `./configure` receives no architecture flag. If the new default stops selecting a single platform, CI could pass while a plain build fails when the secondary Callgrind target compiles without Capstone. Please add a test that configures without either architecture flag and checks that no secondary platform is selected.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.|
Superseded by #42, which uses the COD-3590 branch name. |
Merging this PR will not alter performance
Comparing Footnotes
|
Capstone is compiled for the primary platform only, and cycledecode.c does not build without it. On a bi-arch host with 32-bit multilib, a plain ./configure also enabled the secondary x86 Callgrind, which then failed in make with a missing capstone/capstone.h and the CLG_WITH_CAPSTONE #error.
Default to --enable-only64bit unless --enable-only64bit or --enable-only32bit was given either way, and fail at configure time with a clear message if a secondary platform is still requested.