Conversation
Ports the isRoot handling of the Zod generators (Code-Hex#1423) to valibot, so a list field's directives pipe the outermost v.array(...) and its items get none. Replaces the list field todo with a test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #489 / #1423, which fixed this for the Zod generators.
The valibot generator still applies a list field's directives to each item, so a length constraint on an array
limits every element instead of the array:
This ports the
isRoothandling ofgenerateFieldTypeZodSchematogenerateFieldTypeValibotSchema: the directivesgo on the outermost
v.array(...)of the field (non-null and nullable lists alike), and items get none. Scalar fieldsare unchanged, and
notAllowEmptyStringstill applies to string items.The
it.todo('list field')under "issues #19" is now a real test covering[String!]!,[String!]and a nested[[String!]!]!.🤖 Generated with Claude Code