Repository navigation
Class pace-done added to body multiple times #515
Description
Activity
Same issue over here. I'm using v1.2.4
Having the same issue also. Keeps adding unnecessary spaces too
Same for me
There is a pipe within the search pattern to replace pace-done by class pace-running which should not be in.
Replace line 276:
document.body.className = document.body.className.replace(/(pace-done )|/, 'pace-running ');by
document.body.className = document.body.className.replace(/(pace-done )/, 'pace-running ');Afterwards it will stop that nasty misbehavior.
Regards
-AndiReacted by wsteven24@browniebraun Would you like to open a PR with this change?
Hi @matt-snider Could this be added to the next update please? It's still happening on the latest version (https://cdn.jsdelivr.net/npm/pace-js@latest/pace.min.js)
Hi @michaelthedev! Have you submitted a PR?
oh, i tagged the wrong person. I just created the PR (#547)
I wasn't able to apply the fix on the minified version
Reacted by Toni Villena
Hi there,
Thanks for this great library! It looks great and works very well, although I am having one minor issue.
Recently I noticed that on each navigation or request, the
pace-doneclass is being added to body and not properly cleared on the next run. This doesn't affect the functionality, but over time, many duplicate instances of this class accumulate.The fact that no one else has reported this leads me to believe that I might be making a mistake, or there is some issue specific to my setup. But I guess we'll see if anyone else reports the same behaviour. I'm hoping that someone might have some idea what could be causing this.
Some information that might be helpful:
vue-cli-servicewhich useswebpackto bundle everythingimport "pace-js"inmain.ts