Skip to content

London | 26-ITP-May | Mandip Sanger| Sprint 1| Data groups - #1392

Open
mandipsanger wants to merge 18 commits into
CodeYourFuture:mainfrom
mandipsanger:sprint-1
Open

London | 26-ITP-May | Mandip Sanger| Sprint 1| Data groups#1392
mandipsanger wants to merge 18 commits into
CodeYourFuture:mainfrom
mandipsanger:sprint-1

Conversation

@mandipsanger

@mandipsanger mandipsanger commented Aug 6, 2026 •
edited
Loading

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

completed sprint 1 course work

Task Id

CYF-1083

Questions

N/A

@mandipsanger mandipsanger added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. labels Aug 6, 2026
LonMcGregor
LonMcGregor reviewed Aug 8, 2026
View reviewed changes

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good, just one minor thing in dedupe

Comment thread Sprint-1/implement/dedupe.js
Comment thread Sprint-1/implement/dedupe.js Outdated
Comment thread Sprint-1/implement/max.js Outdated
@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 8, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@mandipsanger mandipsanger added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 10, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 10, 2026
@github-actions

This comment has been minimized.

Sign in to view
@mandipsanger mandipsanger changed the title London | 26-ITP-May | Mandip Sanger| Sprint-1| Course work London | 26-ITP-May | Mandip Sanger| Sprint-1| Data Groups Aug 10, 2026
@github-actions

This comment has been minimized.

Sign in to view
@mandipsanger mandipsanger changed the title London | 26-ITP-May | Mandip Sanger| Sprint-1| Data Groups London | 26-ITP-May | Mandip Sanger| Sprint 1| Data groups Aug 10, 2026
@mandipsanger mandipsanger added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 10, 2026
LonMcGregor
LonMcGregor reviewed Aug 11, 2026
View reviewed changes

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dedupe file looks fine now, I see you may have accidentally removed the invert file? was that intentional?

@LonMcGregor LonMcGregor removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 11, 2026
@LonMcGregor LonMcGregor added the Reviewed Volunteer to add when completing a review with trainee action still to take. label Aug 11, 2026
@mandipsanger

mandipsanger commented Aug 11, 2026

Copy link
Copy Markdown
Author

I thought I made changes in orginial file and was working in Sprint 2 so I have replaced with original. AS invert was in sprint 2 so I forget to change the branch before I start work.

@LonMcGregor

LonMcGregor commented Aug 11, 2026

Copy link
Copy Markdown

OK. In that case, this task is done now

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 11, 2026
@github-actions

github-actions Bot commented Sep 15, 2026

Copy link
Copy Markdown

The files changed in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the 'files changed' tab at the top of the page.

Here is an example of a file that has been changed on this branch but shouldn't be: Sprint-1/fix/median.js

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@mandipsanger mandipsanger removed the 📅 Sprint 1 Assigned during Sprint 1 of this module label Sep 15, 2026
@github-actions

github-actions Bot commented Sep 15, 2026

Copy link
Copy Markdown

The files changed in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the 'files changed' tab at the top of the page.

Here is an example of a file that has been changed on this branch but shouldn't be: Sprint-1/fix/median.js

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Data-Groups The name of the module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mandipsanger @LonMcGregor