London | 26-ITP-Sep | Mandip Sanger| Sprint 3 | Quote generator - #1456
Open
mandipsanger wants to merge 9 commits into
Open
mandipsanger wants to merge 9 commits into
mandipsanger wants to merge 9 commits into
Conversation
mandipsanger
added
the
Needs Review
Author
|
I have already made pr to this but couldnot find it may be in coursework so doing it now again |
LonMcGregor
reviewed
Sep 1, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
The app works, but you should not change parts of the code that are not intended to be changed. If you removed quotes for testing, can you restore them when opening the PR?
LonMcGregor
added
Reviewed
mandipsanger
changed the title
Author
|
could you please point out which one is change. Is it in Array of objects with two properties authour and quote. Are there any quotes missing? I can add or replace from original. |
Added multiple quotes to the quotes array while preserving the existing structure. The new quotes include various authors and motivational messages.
mandipsanger
added
Needs Review
|
When I test this, now the app does not work. I only see an empty page and there are no quotes. Have you fully tested this before you updated the PR? |
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Task Code
CYF-1096
Changelist
Quote generator app