Skip to content

London | 26-ITP-Sep | Yonatan Teklemariam Weldeslassie | Sprint 1 | Wireframe - #1478

Open
Yonatanteklemariam wants to merge 17 commits into
CodeYourFuture:mainfrom
Yonatanteklemariam:feature/wireframe
Open

London | 26-ITP-Sep | Yonatan Teklemariam Weldeslassie | Sprint 1 | Wireframe#1478
Yonatanteklemariam wants to merge 17 commits into
CodeYourFuture:mainfrom
Yonatanteklemariam:feature/wireframe

Conversation

@Yonatanteklemariam

@Yonatanteklemariam Yonatanteklemariam commented Sep 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF 0000

Changelist

created a wireframe according to the requirements set on the module.

Questions

@Yonatanteklemariam
Resolve merge conflict in style.css
ce36dda
@Yonatanteklemariam
Resolve merge conflict in index.html
aad4ec4
@Yonatanteklemariam
Update index.html
076fec2 
Updated the URL of the hero image into the original image source
@Yonatanteklemariam
Update index.html
9b626e4 
Updated the READ MORE URL into the original page
@Yonatanteklemariam
Update index.html
b2e1f90 
Updated the BING URLs into the original web page sources
@Yonatanteklemariam
Update index.html
7225c8e 
Updated the telephone link, changed the address and deleted the link for the address
@Yonatanteklemariam
Update style.css
fd424ee 
Added fixed position property to the footer.
@Yonatanteklemariam
Update style.css
e0bb355 
Removed extra comments and cleaned up CSS.
@Yonatanteklemariam
fixed the overlapping of the footer.
b0c001e
@Yonatanteklemariam
Enhance styles with CSS variables and layout adjustments
8a53d16 
Fixed the overlapping footer
@Yonatanteklemariam
Merge branch 'feature/wireframe' of https://github.com/Yonatanteklema…
2a47040 
…riam/Module-Onboarding into feature/wireframe
@Yonatanteklemariam
Merge branch 'feature/wireframe' of https://github.com/Yonatanteklema…
a51202b 
…riam/Module-Onboarding into feature/wireframe
@Yonatanteklemariam
fixed merge conflicts in css file and added padding bottom to the sma…
db76c3c 
…ll articles section prevent overlapping with the footer.
@Yonatanteklemariam
fixed the read more button on the main article corresponding to the o…
c477678 
…ther buttons in the small articles section
@Yonatanteklemariam
aligned the readmore button on the page
521763f
@netlify

netlify Bot commented Sep 8, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit e8d1cfe
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a9ff9520a95500008bd2f48
😎 Deploy Preview https://deploy-preview-1478--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 82 (🔴 down 4 from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@Yonatanteklemariam Yonatanteklemariam added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 8, 2026
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 8, 2026
@Yonatanteklemariam Yonatanteklemariam added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 8, 2026
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 8, 2026
@Yonatanteklemariam Yonatanteklemariam changed the title London | 26-ITP-Sep | Yonatan Teklemariam Weldeslassie | Sprint 1 | Feature/wireframe London | 26-ITP-Sep | Yonatan Teklemariam Weldeslassie | Sprint 1 | wireframe Sep 8, 2026
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@Yonatanteklemariam Yonatanteklemariam added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 8, 2026
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 8, 2026
@Yonatanteklemariam Yonatanteklemariam changed the title London | 26-ITP-Sep | Yonatan Teklemariam Weldeslassie | Sprint 1 | wireframe London | 26-ITP-Sep | Yonatan Teklemariam Weldeslassie | Sprint 1 | Wireframe Sep 8, 2026
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@Yonatanteklemariam Yonatanteklemariam added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 8, 2026
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 8, 2026
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

2 similar comments
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Yonatanteklemariam