London | 26-ITP-Sep | Yonatan Teklemariam Weldeslassie | Sprint 3 | Coursework - #1487
Open
Yonatanteklemariam wants to merge 8 commits into
Open
Yonatanteklemariam wants to merge 8 commits into
Yonatanteklemariam wants to merge 8 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Yonatanteklemariam
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Sep 14, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work on this. It's nearly complete. Good work also attempting the stretch task, I've left a comment there if you want to improve it further
|
|
||
| if (hours > 12) { | ||
| return `${hours - 12}:00 pm`; | ||
| return `${hours - 12}:${minutes.toString().padStart(2, "0")} pm`; |
There was a problem hiding this comment.
Notice how the formatting in the template string for the minutes part is the same each time? Could this be simplified so the formatting is only done in one place?
Author
There was a problem hiding this comment.
Hi Lon, Thanks for your feedback, I actually corrected the formatting accordingly. I would appreciate if you could look at it and put your review, thanks.
LonMcGregor
added
Reviewed
… in template literals
Yonatanteklemariam
added
Needs Review
LonMcGregor
reviewed
Sep 15, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Great, hopefully it is clear here that it makes for code that is easier to read and maintain. Task complete!
LonMcGregor
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1053
Changelist
Completed the coursework set out in Sprint 3.
Questions