-
-
Notifications
You must be signed in to change notification settings - Fork 546
Cape Town | 26-ITP-SEPT | Lamla Kamana | Sprint 1 | Form Controls #1489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lamlakamana-oss
wants to merge
7
commits into
CodeYourFuture:main
Choose a base branch
from
lamlakamana-oss:feature/form-controls
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+66
−5
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0527d28
Add name field with required and pattern validation
lamlakamana-oss db804ea
Add email field with required validation
lamlakamana-oss b3a5762
Add clour field with radio buttons
lamlakamana-oss c9f584d
Add with dropdown validation
lamlakamana-oss 612d7a1
Fix doctype and improve touch target sizing
lamlakamana-oss ba0cad3
Move CSS to external stylesheet per review feedback
lamlakamana-oss 3bba3ba
Fix indentation in Form-Controls/index.html
lamlakamana-oss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,72 @@ | ||
| <!DOCTYPE html> | ||
| <!doctype html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge" /> | ||
| <title>My form exercise</title> | ||
| <meta name="description" content="" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| <link rel="stylesheet" href="style.css" /> | ||
| </head> | ||
| <body> | ||
| <header> | ||
| <h1>Product Pick</h1> | ||
| </header> | ||
| <main> | ||
| <form> | ||
| <!-- write your html here--> | ||
| <!-- | ||
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
| Requirements: | ||
| - Name: required, at least 2 non-space characters | ||
| - Email: required, valid email format | ||
| - Colour: required, choose 1 of 3 options | ||
| - Size: required, choose 1 of 6 sizes | ||
| - No form action needed for this project | ||
| --> | ||
| <div class="field"> | ||
| <label for="name">Name</label> | ||
| <input | ||
| type="text" | ||
| id="name" | ||
| name="name" | ||
| pattern=".*\S.*\S.*" | ||
| required | ||
| /> | ||
| </div> | ||
| <div class="field"> | ||
| <label for="email">Email</label> | ||
| <input type="email" id="email" name="email" required /> | ||
| </div> | ||
| <fieldset> | ||
| <legend>Colour</legend> | ||
|
|
||
| <label> | ||
| <input type="radio" name="colour" value="black" required /> Black | ||
| </label> | ||
|
|
||
| <label> | ||
| <input type="radio" name="colour" value="white" /> White | ||
| </label> | ||
|
|
||
| <label> <input type="radio" name="colour" value="red" /> Red </label> | ||
| </fieldset> | ||
| <div class="field"> | ||
| <label for="size">Size</label> | ||
| <select id="size" name="size" required> | ||
| <option value="">Select a size</option> | ||
| <option value="XS">XS</option> | ||
| <option value="S">S</option> | ||
| <option value="M">M</option> | ||
| <option value="L">L</option> | ||
| <option value="XL">XL</option> | ||
| <option value="XXL">XXL</option> | ||
| </select> | ||
| </div> | ||
| <button type="submit">Submit</button> | ||
| </form> | ||
| </main> | ||
| <footer> | ||
| <!-- change to your name--> | ||
| <p>By HOMEWORK SOLUTION</p> | ||
| <p>By Lamla Kamana</p> | ||
| </footer> | ||
| </body> | ||
| </html> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| input[type="radio"] { | ||
| width: 20px; | ||
| height: 20px; | ||
| margin: 8px; | ||
| } | ||
|
|
||
| label { | ||
| display: inline-flex; | ||
| align-items: center; | ||
| padding: 6px 4px; | ||
| } | ||
|
|
||
| button[type="submit"] { | ||
| padding: 10px 20px; | ||
| min-height: 44px; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.