Manchester | 25-ITP-Sep | Fatima Rouchi | Sprint 1 | Form Controls - #1492
Open
fatimarouchi wants to merge 12 commits into
Open
fatimarouchi wants to merge 12 commits into
fatimarouchi wants to merge 12 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
fatimarouchi
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
fatimarouchi
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
fatimarouchi
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
fatimarouchi
changed the title
fatimarouchi
added
the
Needs Review
cjyuan
added
the
Review in progress
cjyuan
reviewed
Sep 14, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Note: You don't have to include the PR title in the PR description.
Comment on lines
+26
to
+40
| <legend>T-Shirt Color</legend> | ||
| <label><input type="radio" id="red" name="tshirt-color" value="red" required>Red</label><br> | ||
| <label><input type="radio" id="blue" name="tshirt-color" value="blue" required>Blue</label><br> | ||
| <label><input type="radio" id="green" name="tshirt-color" value="green" required>Green</label><br> | ||
| </fieldset><br> | ||
|
|
||
| <!-- fieldset for tshirt size--> | ||
| <fieldset> | ||
| <legend>T-Shirt Size</legend> | ||
| <label><input type="checkbox" id="extra-small" name="tshirt-size" value="extra-small" required>XS</label><br> | ||
| <label><input type="checkbox" id="small" name="tshirt-size" value="small" required>S</label><br> | ||
| <label><input type="checkbox" id="medium" name="tshirt-size" value="medium" required>M</label><br> | ||
| <label><input type="checkbox" id="large" name="tshirt-size" value="large" required>L</label><br> | ||
| <label><input type="checkbox" id="extra-large" name="tshirt-size" value="extra-large" required>XL</label><br> | ||
| </fieldset><br> |
Contributor
There was a problem hiding this comment.
-
Why use
type="radio"for T-Shirt color, andtype="checkbox"for T-Shirt size? -
Also, try using AI to find out how we could simplify the markup for radio buttons.
Author
There was a problem hiding this comment.
Thank you for your feedback, hopefully I managed to correct the mistakes.
Comment on lines
+17
to
+22
| <label for="name">Name:</label> | ||
| <input type="text" id="name" name="name" required pattern=".*\S.*\S.*"><br><br> | ||
|
|
||
| <!-- label for the email input --> | ||
| <label for="email">Email:</label> | ||
| <input type="email" id="email" name="email" required><br><br> |
Contributor
There was a problem hiding this comment.
Note: Chrome Developer Tools and AI tools may provide useful insights into how we can further improve our implementation. While you are not required to follow their suggestions in every exercise, taking the time to consider them can often help us learn more effectively.
Here's an example,
Comment on lines
+26
to
+29
| <legend>T-Shirt Color</legend> | ||
| <label><input type="radio" id="red" name="tshirt-color" value="red" required>Red</label><br> | ||
| <label><input type="radio" id="blue" name="tshirt-color" value="blue" required>Blue</label><br> | ||
| <label><input type="radio" id="green" name="tshirt-color" value="green" required>Green</label><br> |
Contributor
There was a problem hiding this comment.
Indentation is slightly off.
Suggestion:
- Look up the benefits of using a code formatter.
- Install the Prettier extension for VS Code, then:
- Use VS Code's Format Document feature to format your code.
- Optionally, enable Format On Save and Format On Paste to keep your code consistently formatted.
Resource: Visual Studio Code - Formatting
Note: The formatter may not work correctly if your code contains syntax errors.
cjyuan
added
Reviewed
fatimarouchi
added
the
Needs Review
cjyuan
reviewed
Sep 17, 2026
| <!-- | ||
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
| <form method="get"> |
Contributor
There was a problem hiding this comment.
Why introduce the method="get" attribute explicitly?
Author
There was a problem hiding this comment.
GET is useful to search or view information, VS code made me add it and then later I realised it wasn't needed.
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
CYF-1004
Changelist