London | 26-Sep-ITP| Frumentius Tesfay | Sprint 1 | Form-controls - #1494
Open
Frumentius-Rev wants to merge 11 commits into
Open
Frumentius-Rev wants to merge 11 commits into
Frumentius-Rev wants to merge 11 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
abdishakoor-dev
added
Needs Review
abdishakoor-dev
left a comment
abdishakoor-dev
left a comment
Contributor
There was a problem hiding this comment.
All the requirements are met and the form works. Using fieldset and legend for the colour radios is the right call, and the commits are small and clear.
Two things to sort before I mark this Complete, both quick:
- The HTML validator from the README checklist (https://validator.w3.org/) reports one error, on line 45.
- Prettier fails on both files. Run
npx prettier --write Form-Controlsfrom the repo root and push. That will fix line 45 as well.
Add the Needs Review label again once you've pushed.
| <label for="size">T-shirt Size</label> | ||
| <select name="size" id="size" required> | ||
|
|
||
| <option value=""disabled selected>Choose</option> |
Contributor
There was a problem hiding this comment.
Missing space between value="" and disabled. This is the validator's one error.
abdishakoor-dev
added
Reviewed
abdishakoor-dev
added
Needs Review
abdishakoor-dev
left a comment
abdishakoor-dev
left a comment
Contributor
There was a problem hiding this comment.
Formatted and the validator is clean. Nothing left to do, marking this Complete. Well done.
abdishakoor-dev
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1004
Changelist
I have completed all the required form controls and added CSS styling to the form.