London | 26-ITP-SEP | Sakiya Mayow | Sprint 1 | Form Controls - #1500
Open
zakiaao-tech wants to merge 3 commits into
Open
London | 26-ITP-SEP | Sakiya Mayow | Sprint 1 | Form Controls#1500zakiaao-tech wants to merge 3 commits into
zakiaao-tech wants to merge 3 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
zakiaao-tech
added
the
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1004
Changelist
I have added the required name and email fields with validation.
I added 3 colour options.
I added 6 T-shirt sizes: XS, S, M, L, XL, XXL.
Questions
I did not use Javascript, will it be okay or do I have to redo it?
Also I am unsure if the lighthouse inspection worked or not.