Skip to content

Manchester | 26-Sep-ITP | Mathew Shaibu | Sprint 1 | Form Controls - #1505

Open
MattCarolus10 wants to merge 24 commits into
CodeYourFuture:mainfrom
MattCarolus10:feature/form-controls
Open

MattCarolus10 wants to merge 24 commits into
CodeYourFuture:mainfrom
MattCarolus10:feature/form-controls

Conversation

@MattCarolus10

@MattCarolus10 MattCarolus10 commented Sep 12, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1004

Changelist

  • Built form controls in index.html with text input, email and select downdrops
  • Added labels, validation, submit/reset button and autocomplete attribute
  • Cleaned up leftover template comments

Questions

I struggled to get back to this project on VSCode, it kept taking me to the main CYF repo, but I figured it out making some research and running some code suggested. How do I avoid forking from CYF repo to avoid reocourence in the future?

@netlify

netlify Bot commented Sep 12, 2026

Copy link
Copy Markdown

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 083e688
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6aa918d9299c040008171bfe
😎 Deploy Preview https://deploy-preview-1505--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 83 (🔴 down 3 from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

@MattCarolus10 MattCarolus10 changed the title Manchester | 26-Sep-ITP | Mathew Shaibu | Sprint 1 | CYF-1004 Manchester | 26-Sep-ITP | Mathew Shaibu | Sprint 1 | Form-Controls Sep 12, 2026
@github-actions

This comment has been minimized.

@MattCarolus10 MattCarolus10 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 12, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 12, 2026
@MattCarolus10 MattCarolus10 changed the title Manchester | 26-Sep-ITP | Mathew Shaibu | Sprint 1 | Form-Controls Manchester | 26-Sep-ITP | Mathew Shaibu | Sprint 1 | Form Controls Sep 12, 2026
@github-actions

This comment has been minimized.

@MattCarolus10 MattCarolus10 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 12, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 12, 2026
@MattCarolus10 MattCarolus10 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 12, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I just have a few suggestions.

Comment thread Form-Controls/index.html Outdated
</form>
</main>
<footer>
<!-- change to your name-->

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If comments are no longer needed in the final implementation, you could remove them to keep the code clean.

Comment thread Form-Controls/index.html
Comment on lines +19 to +27
<div>
<label for="name">Full Name:</label>
<input type="text" name="name" id="name" placeholder="Full name" required pattern=".*\S.*\S.*">
</div>

<div>
<label for="email">Email:</label>
<input type="email" name="email" id="email" placeholder="Email address" required>
</div>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Chrome Developer Tools and AI tools may provide useful insights into how we can further improve our implementation. While you are not required to follow their suggestions in every exercise, taking the time to consider them can often help us learn more effectively.

Here's an example,

Image

Comment thread Form-Controls/index.html
Comment on lines +63 to +66
</footer>
</body>

</html> No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is well formatted. Are they formatted manually?

Suggestion:

  • Look up the benefits of using a code formatter.
  • Install the Prettier extension for VS Code, then:
    • Use VS Code's Format Document feature to format your code.
    • Optionally, enable Format On Save and Format On Paste to keep your code consistently formatted.

Resource: Visual Studio Code - Formatting

Note: The formatter may not work correctly if your code contains syntax errors.

@MattCarolus10 MattCarolus10 Sep 14, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I formatted it using the right click "format documents". Thanks for this comment I really appreciate it.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 14, 2026
@cjyuan

cjyuan commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Could you use an AI tool to find out "What's the purpose of the Changelist section in a PR description?" and then update the Changelist section of this PR accordingly?

@MattCarolus10 MattCarolus10 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 15, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Well done.


I struggled to get back to this project on VSCode, it kept taking me to the main CYF repo, but I figured it out making some research and running some code suggested. How do I avoid forking from CYF repo to avoid reocourence in the future?

Once you have forked a repo to your GitHub account, you would not be able to fork the same repo again unless you deleted the forked repo.

Do you mean "clone"? Which URL did you used when you cloned the repo? Based on what you described, you might have cloned CYF's repo instead of yours. You can ask AI for the Git command to show the upstream URL of your repo on your computer.

It's better to ask a volunteer in person on Saturday.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants