Manchester | 26-Sep-ITP | Mathew Shaibu | Sprint 1 | Form Controls - #1505
MattCarolus10 wants to merge 24 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cjyuan
left a comment
There was a problem hiding this comment.
Code looks good. I just have a few suggestions.
| </form> | ||
| </main> | ||
| <footer> | ||
| <!-- change to your name--> |
There was a problem hiding this comment.
If comments are no longer needed in the final implementation, you could remove them to keep the code clean.
| <div> | ||
| <label for="name">Full Name:</label> | ||
| <input type="text" name="name" id="name" placeholder="Full name" required pattern=".*\S.*\S.*"> | ||
| </div> | ||
|
|
||
| <div> | ||
| <label for="email">Email:</label> | ||
| <input type="email" name="email" id="email" placeholder="Email address" required> | ||
| </div> |
There was a problem hiding this comment.
| </footer> | ||
| </body> | ||
|
|
||
| </html> No newline at end of file |
There was a problem hiding this comment.
Code is well formatted. Are they formatted manually?
Suggestion:
- Look up the benefits of using a code formatter.
- Install the Prettier extension for VS Code, then:
- Use VS Code's Format Document feature to format your code.
- Optionally, enable Format On Save and Format On Paste to keep your code consistently formatted.
Resource: Visual Studio Code - Formatting
Note: The formatter may not work correctly if your code contains syntax errors.
There was a problem hiding this comment.
I formatted it using the right click "format documents". Thanks for this comment I really appreciate it.
|
Could you use an AI tool to find out "What's the purpose of the Changelist section in a PR description?" and then update the Changelist section of this PR accordingly? |
cjyuan
left a comment
There was a problem hiding this comment.
Changes look good. Well done.
I struggled to get back to this project on VSCode, it kept taking me to the main CYF repo, but I figured it out making some research and running some code suggested. How do I avoid forking from CYF repo to avoid reocourence in the future?
Once you have forked a repo to your GitHub account, you would not be able to fork the same repo again unless you deleted the forked repo.
Do you mean "clone"? Which URL did you used when you cloned the repo? Based on what you described, you might have cloned CYF's repo instead of yours. You can ask AI for the Git command to show the upstream URL of your repo on your computer.
It's better to ask a volunteer in person on Saturday.


Learners, PR Template
Self checklist
Task code
CYF-1004
Changelist
Questions
I struggled to get back to this project on VSCode, it kept taking me to the main CYF repo, but I figured it out making some research and running some code suggested. How do I avoid forking from CYF repo to avoid reocourence in the future?