South Africa | 26-ITP | Quentin Gwele | Sprint 1 | Form Controls - #1510
Open
lwandogwele52-ui wants to merge 3 commits into
Open
lwandogwele52-ui wants to merge 3 commits into
lwandogwele52-ui wants to merge 3 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
lwandogwele52-ui
added
the
Needs Review
tiakavousi
added
Review in progress
tiakavousi
reviewed
Sep 15, 2026
tiakavousi
left a comment
tiakavousi
left a comment
There was a problem hiding this comment.
Nice start! A few comments to help you complete the assignment:
- Please resolve all the comments
- Please add a CSS file and use it to style your HTML page, as required by the assignment.
- After pushing your changes , please add the Need Review label
| <option value="black">Black</option> | ||
| </select> | ||
| </div> | ||
| <!-- 4. T-shirt Size (6 options: XS, S, M, L, XL, XXL) --> |
There was a problem hiding this comment.
Since there are only three colour options, would radio buttons provide a better UX here? They allow users to see all available options immediately without opening a dropdown. The current is still valid for a single-choice selection.
|
|
||
| <!-- Submit Button --> | ||
| <button type="submit">Submit Order</button> | ||
| <header> |
There was a problem hiding this comment.
The <header> should come before the <main> in the document structure.
A more semantic order would be:
<header> → <main> → <footer>
This makes the page structure clearer for browsers, assistive technologies, and other tools that rely on semantic HTML.
| this will also help you fill in your PR message later--> | ||
| </form> | ||
| </main> | ||
| <footer> |
There was a problem hiding this comment.
Please also check your <footer>: the closing </footer> tag is missing.
Also, please follow the requirement mentioned in the comment by adding a <p> element containing your name inside the footer.
tiakavousi
added
Reviewed
lwandogwele52-ui
added
the
Needs Review
tiakavousi
reviewed
Sep 16, 2026
tiakavousi
left a comment
tiakavousi
left a comment
There was a problem hiding this comment.
Nice work resolving the comments,
on the CSS , the form is clearly styled and the selectors are generally appropriate.
A few things to consider:
- Avoid styling all
divelements globally with A class name would be more specific and maintainable. - Consider adding a hover state to the submit button to give the user visual feedback when interacting with it.
tiakavousi
removed
the
Needs Review
Author
|
Thanks Tia! I've refactored the global div styles to use .form-group and added a hover effect to the submit button.
… On 16 Sep 2026, at 10:35, Tia ***@***.***> wrote:
@tiakavousi commented on this pull request.
Nice work resolving the comments,
on the CSS , the form is clearly styled and the selectors are generally appropriate.
A few things to consider:
Avoid styling all div elements globally with A class name would be more specific and maintainable.
Consider adding a hover state to the submit button to give the user visual feedback when interacting with it.
—
Reply to this email directly, view it on GitHub <#1510?email_source=notifications&email_token=CFBVDQVLQW7JH7OMBV2FXLT5PJGFLA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMRSGAZTSNBRGQ4KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-5220394148>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/CFBVDQUPHG3JD7ZXBXMG3TD5PJGFLAVCNFSNUABFKJSXA33TNF2G64TZHM4DSOJQGI2DGMRUHNEXG43VMU5TKNBTGYZTIOJXGQ32C5QC>.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS <https://github.com/notifications/mobile/ios/CFBVDQR2ZO5EDMCKZVZ25MT5PJGFLA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMRSGAZTSNBRGQ4KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG> and Android <https://github.com/notifications/mobile/android/CFBVDQUB477ZFKOHEL6U5AT5PJGFLA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMRSGAZTSNBRGQ4KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>. Download it today!
You are receiving this because you authored the thread.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1004
Changelist