London | 26 ITP SEP | Russom Gebremeskel | Sprint 3 | Coursework by russom-g · Pull Request #1520 · CodeYourFuture/Module-JavaScript-Fundamentals

russom-g · 2026-09-13T22:44:03Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1053

Changelist

Code error fixed, debugged, and refactored as reqiured.

netlify · 2026-09-13T22:44:08Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`f39cb79`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6ab0530925c49c000894688f
😎 Deploy Preview	https://deploy-preview-1520--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

abdishakoor-dev

This is in good shape. The debug section is the strongest part: all three files run and give the right output, and your explanation in 2.js about the function ignoring its argument is exactly right. Good to see you attempt the stretch too.

Four things to look at:

1-key-errors/1.js line 29, see my comment.
1-key-errors/2.js line 34, see my comment.
3-mandatory-implement/3-to-pounds.js, see my comment.
4-mandatory-interpret/time-format.js answers d) and e), see my comment.
Could you run Prettier on the files you have changed? Most of them are not formatted at the moment.

Add the Needs Review label again when you have pushed.

abdishakoor-dev · 2026-09-20T12:53:37Z

 // =============> write your new code here
+
+function convertToPercentage(decimalNumber) {
+  return percentage = `${decimalNumber * 100}%`;


The original had two lines here, const percentage = ... and then return percentage. You have combined them into one, but the const has gone, so percentage is no longer being declared. Does this function need that variable at all, or could you return the template literal straight away?

The function works when I test it. However, I should have kept the const percentage declaration as it is. Or return the template literal straight away.

abdishakoor-dev · 2026-09-20T12:53:37Z

+    return num * num;
+}
+
+console(square(3));


Run this line on its own. console is an object, not a function, so this throws. What did you mean to call?

Separately, your prediction on line 9 says ReferenceError, and your answer on line 19 correctly says SyntaxError. Worth thinking about why a ReferenceError could never happen in this particular file: what has to succeed before any line of a file can run at all?

I was testing the function and forgot to delete the whole console(square(3)) line.

Yes my prediction was wrong. ReferenceError happens when a variable is not declared properly. Or a local variable is used in a global scope.

abdishakoor-dev · 2026-09-20T12:53:37Z


 // You should call this function a number of times to check it works for different inputs
+
+function toPound(priceInPence) {


Two things here. The task asks for a function called toPounds and this one is toPound. And it says to call it a number of times to check it works for different inputs, where there is only the one call with "399p". What else would you try it with?

I tested it with: 0, 00, 000, 01, 9, 58749 ...

abdishakoor-dev · 2026-09-20T12:53:37Z

 // d) What is the value assigned to num when pad is called for the last time in this program?  Explain your answer
 // =============> write your answer here

+// The value assigned to num is 1. This is because 1 is the last character in the string 61


The value 1 is right, but have another look at why. remainingSeconds comes from seconds % 60 on line 12, not from taking the last character out of the string "61". What is 61 % 60, and is the result a string or a number? Answer e) has the same reasoning in it.

61 % 60 is 61 divided by 60 which is 1(totalMinutes) and the leftover 1 assigned to remainingSeconds

russom added 13 commits September 13, 2026 10:23

Answer questions, explain and refactor code.

1df46e8

Predict, fix, and explain code

f00caed

Uncomment out function

507f02a

Predict, explain and fix code

6f4e46f

Predict, explain and fix code

9aadee0

Update comment

6018cd5

Predict, explain, and fix code

444757f

Predict, explain, and fix code

8245202

Implement a BMI calculating function

4064cd8

Remove console.log

2bdebf4

Implement upper snake case converter

849b970

Refactor code by removing padEnd method.

c3b0ad5

Refactor code into reusable function

0f95d9b

This comment has been minimized.

Sign in to view

russom and others added 13 commits September 13, 2026 23:57

Remove Sprint 2 to-pounds exercise

7b9c2e2

Answer and explain how code works

e4bb558

Ignore 3-to-pounds.js

3eee2ad

Write test for 24:00 and 12:00am

6bece94

Add if condition to compare time

5eba71d

Add more ege case tets.

8ecde42

Merge branch 'CodeYourFuture:main' into coursework/sprint-3

8c33243

Remove wrongly pushed percentage change file

7d6f51d

Update code.

db95486

Remove wrongly pushed percentage change file

70e2b1b

Remove wrongly pushed to-pounds file

47cee31

Remove wrongly pushed gitignore file

a7d328c

Restore Sprint 2 files

21c9992

russom-g added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 17, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 17, 2026

russom-g added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 17, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 17, 2026

This comment has been minimized.

Sign in to view

russom-g added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 19, 2026

abdishakoor-dev reviewed Sep 20, 2026

View reviewed changes

abdishakoor-dev added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 20, 2026

russom added 3 commits September 20, 2026 19:58

Remove redundant undeclared percentage variable

172a529

Delete not needed print statement

b0d0f7c

Remove padEnd method

f39cb79

Navigation Menu

Uh oh!

London | 26 ITP SEP | Russom Gebremeskel | Sprint 3 | Coursework - #1520

London | 26 ITP SEP | Russom Gebremeskel | Sprint 3 | Coursework#1520
russom-g wants to merge 29 commits into
CodeYourFuture:mainfrom
russom-g:coursework/sprint-3

russom-g commented Sep 13, 2026 •

edited

Loading

Uh oh!

netlify Bot commented Sep 13, 2026 •

edited

Loading

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

abdishakoor-dev left a comment

Uh oh!

abdishakoor-dev Sep 20, 2026

Uh oh!

russom-g Sep 20, 2026

Uh oh!

abdishakoor-dev Sep 20, 2026

Uh oh!

russom-g Sep 20, 2026

Uh oh!

abdishakoor-dev Sep 20, 2026

Uh oh!

russom-g Sep 20, 2026

Uh oh!

abdishakoor-dev Sep 20, 2026

Uh oh!

russom-g Sep 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		// You should call this function a number of times to check it works for different inputs

		function toPound(priceInPence) {

Uh oh!

Conversation

russom-g commented Sep 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Task code

Changelist

Uh oh!

netlify Bot commented Sep 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

russom-g commented Sep 13, 2026 •

edited

Loading

netlify Bot commented Sep 13, 2026 •

edited

Loading