Repository navigation
feat(pbs): count the ws bid stream under its own metrics endpoint - #499
Merged
Merged
Conversation
ManuelBilbao
approved these changes
Sep 11, 2026
ninaiiad
approved these changes
Sep 14, 2026
ltitanb
approved these changes
Sep 14, 2026
JasonVranek
added a commit
that referenced
this pull request
Oct 2, 2026
…secrets, rustls bump Brings in #502 (submit-block relay error logging), the v0.11.0-rc2/rc3 releases with the rustls advisory bump, relay headers read from a secret file or env var (#498), and the ws stream metrics endpoint (#499). Conflict resolutions: - relay.rs: kept epbs's relay_headers() helper, shared by the HTTP client and the stream handshake, and moved main's header resolution into it (HeaderSource literal/file/env, sensitive values, the secret-source log line). Its error messages now format the key, which epbs's did not. - config/pbs.rs: one test module holding epbs's unknown-[pbs]-field tests and main's header-source tests. - config/utils.rs: main's RELAY_URL test constant in test_env. - Cargo.lock: main's lockfile, plus only what epbs adds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The websocket bid stream recorded its outcome and time-to-first-bid under
get_header, the same series as the HTTP fallback, so a slot served by the fallback was indistinguishable from one served by the stream. Stream attempts now count underendpoint="get_header_stream"; the fallback keepsget_header.Four new metrics cover what a stream does that HTTP cannot:
relay_stream_connect_latency: websocket handshake duration, with sub-second bucketsrelay_stream_updates: bid updates received per stream windowrelay_stream_invalid_frames_total: frames that could not be parsed as a bidrelay_stream_fallback_total: handshake failures that had budget left to retry over HTTPA handshake answered 2xx instead of 101 now reports the transport error (556) instead of the 2xx, which the stream series would otherwise read as a delivered bid. The two synthetic status codes are compile-time constants.