Repository navigation
Conversation
|
How much work would it be for you to list any limitations to your parser, especially those that are actually relevant in the context of psm_utils? It would probably be interesting to have this as part of the documentation so people can make an informed decision when selecting the parser. On top of that, it might also be interesting to see how computationally expensive it would be to implement any relevant missing features, and use your parser as the default. |
|
I will look over it and check, what information is actually missing / could be missing. |
|
This took some time, but I re-checked and improved the version I created some time ago. My assumption that something would be missing actually only afflicts special IDs like de novo and cases in which amino acids might be substituted (like mentioned in #77). Also, the issue #153 could be considered, but it is for now implemented as in the normal reader. For my testcases (the ones in the repo and some mzids I have lying around), the new reader created exactly the same TSV files in the end as the original implementation. It is on average at least 10x faster, though. Would be great, if you could merge this in. If you have any more questions regarding this, don't hesitate to ask. Merging (and moving the classes correctly) should also fix #22 and #36. |
Hej,
I re-wrote the mzident reader and made it much faster, albeit maybe a bit less complete.
For now, I added the new reader alongside the old one. It does not use Pyteomics, but parses the structure more directly. Hence, it is less complete for complicated files, but should be good for most "normal" ones originating from a single search engine and contain only one search run.
I tested the conversion to TSV on some bigger files from MS-GF+ and Comet (2-20 GB) and the output was exactly identical to the files created by the original reader. But the conversion took only about a tenth of teh time (with equal memory consumption).
Would be great, if you could add this new reader, if you like it. As the conversion of the bigger files (like a combination of TimsTOF files and proteogenomics databases) otherwise takes days :)
Cheers,
Julian